Add setting for opening URLs passed to FreeTube in a new window by OothecaPickle · Pull Request #6242 · FreeTubeApp/FreeTube

OothecaPickle · 2024-11-29T10:38:35Z

Add setting for opening URLs passed to FreeTube in a new window

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Related issue

closes #1501
also relates to #6237

Description

Adds a toggle under General Settings to open freetube:// links in a new window rather than replacing the contents of an existing window.

Screenshots

Testing

Test that freetube:// links opened from other applications are opened in a new window when the added setting is toggled on.

Desktop

OS: macOS
OS Version: 11
FreeTube version: e646a0f
&
OS: Windows
OS Version: Windows 10 21H2
FreeTube version: e646a0f

Additional context

I used some code from @pakoito's #5592.

PikachuEXE · 2024-11-29T12:52:08Z

Are you talking about https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app#overview ?
Maybe the preference name should be updated first

Also I am not sure how/if the doc mentions deep links and if users understand what is freetube:// links

OothecaPickle · 2024-11-29T18:24:29Z

@PikachuEXE

Are you talking about https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app#overview ?

Yes.

Maybe the preference name should be updated first
Also I am not sure how/if the doc mentions deep links and if users understand what is freetube:// links

I agree, but I wasn't sure what else to name it. Do you have any suggestions?

src/renderer/App.js

PikachuEXE · 2024-11-30T06:18:06Z

I found one place mentioning extensions but not sure how to call it
https://docs.freetubeapp.io/usage/browser-extension/

It shouldn't be called "YouTube links" on the preference coz there are many "YT" links in video description/comment etc.

Inviting more members to comment on this

pakoito · 2024-11-30T18:50:17Z

In Android land these are called "Intents" rather than "Links". But tbh I'd be sad if this feature is blocked on a label :D

src/main/index.js

OothecaPickle · 2024-12-01T12:59:01Z

Sorry to bother @pakoito, didn't mean to request another review from you.

OothecaPickle · 2024-12-01T13:19:53Z

static/locales/en-US.yaml

    Fallback to Non-Preferred Backend on Failure: Fallback to Non-Preferred Backend
      on Failure
    Enable Search Suggestions: Enable Search Suggestions
+    Open Links In New Window: Open freetube:// Links in a New Window


Suggested change

Open Links In New Window: Open freetube:// Links in a New Window

Open Links In New Window: Open URLs Passed to FreeTube in a New Window

or maybe "URLs Passed to FreeTube" as this setting also applies to links passed via the command line

I have no objection to changing it to URLs Passed to FreeTube because that does sound clearer. If others think the messaging doesnt sound clear enough then maybe we should opt for implementing an tool tip message that explains what this does?

Or just add tooltip giving examples of redirect extensions (mostly from those right?
Setting External Link Handling has one

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-12-02T21:37:41Z

could someone provide a build for me to test this one 😬

OothecaPickle · 2024-12-02T22:01:35Z

could someone provide a build for me to test this one 😬

@efb4f5ff-1298-471a-8973-3d47447115dc https://github.com/OothecaPickle/FreeTube/actions/runs/12128622135

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-12-02T22:49:00Z

PR LGTM, only thing that should be looked at is the wording of the setting

src/renderer/store/modules/settings.js

PikachuEXE · 2024-12-03T00:40:52Z

static/locales/en-US.yaml

    Fallback to Non-Preferred Backend on Failure: Fallback to Non-Preferred Backend
      on Failure
    Enable Search Suggestions: Enable Search Suggestions
+    Open Links In New Window: Open freetube:// Links in a New Window


Or just add tooltip giving examples of redirect extensions (mostly from those right?
Setting External Link Handling has one

PikachuEXE · 2024-12-03T03:10:29Z

You committed when I am about to comment on it lol

PikachuEXE

Did not test actual link open on mac but someone else tested it already

efb4f5ff-1298-471a-8973-3d47447115dc

Tooltip wording change

static/locales/en-US.yaml

…TubeApp#6242) * open freetube:// links in new window * add setting for opening freetube:// links in new window * fix two windows being opened when link launches freetube * use multiple parameters instead of destructuring assignment * change setting name & add tooltip * minor correction * change tooltip wording

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-05-06T12:24:06Z

Hi @OothecaPickle i noticed some undesired behavior and i would like to know if it possible for you to create a followup PR to fixed these. I noticed this behavior in while testing another PR #6915 (review)

If one instance of FT is minimized LibRedirect will open the video in a new window AND will also unminimize the previously minimized window
If two instances of FT are minimized LibRedirect will open the video in a new window AND will ONLY unminimize the first instance that was previously minimized. So the Second instance that was minimized will stay minimized but the first instance wont.

OothecaPickle added 2 commits November 29, 2024 02:20

open freetube:// links in new window

450a818

add setting for opening freetube:// links in new window

227799e

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 29, 2024

FreeTubeBot enabled auto-merge (squash) November 29, 2024 10:38

pakoito reviewed Nov 29, 2024

View reviewed changes

src/renderer/App.js Outdated Show resolved Hide resolved

PikachuEXE requested review from ChunkyProgrammer, absidue and efb4f5ff-1298-471a-8973-3d47447115dc November 30, 2024 06:18

OothecaPickle marked this pull request as draft December 1, 2024 09:54

auto-merge was automatically disabled December 1, 2024 09:54
Pull request was converted to draft

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 1, 2024

fix two windows being opened when link launches freetube

fad3e57

OothecaPickle marked this pull request as ready for review December 1, 2024 11:33

FreeTubeBot enabled auto-merge (squash) December 1, 2024 11:33

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 1, 2024

absidue reviewed Dec 1, 2024

View reviewed changes

src/main/index.js Outdated Show resolved Hide resolved

use multiple parameters instead of destructuring assignment

c5be564

auto-merge was automatically disabled December 1, 2024 12:43
Head branch was pushed to by a user without write access

FreeTubeBot enabled auto-merge (squash) December 1, 2024 12:43

OothecaPickle requested review from absidue and pakoito December 1, 2024 12:44

OothecaPickle commented Dec 1, 2024

View reviewed changes

absidue removed the request for review from pakoito December 1, 2024 15:09

PikachuEXE requested changes Dec 3, 2024

View reviewed changes

change setting name & add tooltip

db5ce52

auto-merge was automatically disabled December 3, 2024 02:32
Head branch was pushed to by a user without write access

FreeTubeBot enabled auto-merge (squash) December 3, 2024 02:32

OothecaPickle requested a review from PikachuEXE December 3, 2024 02:38

minor correction

5f354be

auto-merge was automatically disabled December 3, 2024 03:09
Head branch was pushed to by a user without write access

FreeTubeBot enabled auto-merge (squash) December 3, 2024 03:10

OothecaPickle changed the title ~~Add setting for opening freetube:// links in new window~~ Add setting for opening URLs passed to FreeTube in a new window Dec 3, 2024

PikachuEXE previously approved these changes Dec 3, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc reviewed Dec 3, 2024

View reviewed changes

static/locales/en-US.yaml Outdated Show resolved Hide resolved

change tooltip wording

9d558e1

auto-merge was automatically disabled December 3, 2024 05:26
Head branch was pushed to by a user without write access

OothecaPickle dismissed PikachuEXE’s stale review via 9d558e1 December 3, 2024 05:26

FreeTubeBot enabled auto-merge (squash) December 3, 2024 05:26

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Dec 3, 2024

View reviewed changes

absidue approved these changes Dec 3, 2024

View reviewed changes

PikachuEXE approved these changes Dec 3, 2024

View reviewed changes

FreeTubeBot merged commit eecb261 into FreeTubeApp:development Dec 3, 2024

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 3, 2024

randomoOCoder mentioned this pull request Jan 11, 2025

Open every video in new window for Freetube instead of same. libredirect/browser_extension#1031

Closed

efb4f5ff-1298-471a-8973-3d47447115dc mentioned this pull request May 6, 2025

Added hide to tray on minimize option #6915

Merged

4 tasks

PikachuEXE mentioned this pull request May 31, 2025

Fix opening URL in a new window restores main window (in Windows) #7489

Merged

4 tasks

	Open Links In New Window: Open freetube:// Links in a New Window
	Open Links In New Window: Open URLs Passed to FreeTube in a New Window

Conversation

OothecaPickle commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add setting for opening URLs passed to FreeTube in a new window

Pull Request Type

Related issue

Description

Screenshots

Testing

Desktop

Additional context

Uh oh!

PikachuEXE commented Nov 29, 2024

Uh oh!

OothecaPickle commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

PikachuEXE commented Nov 30, 2024

Uh oh!

pakoito commented Nov 30, 2024

Uh oh!

Uh oh!

OothecaPickle commented Dec 1, 2024

Uh oh!

OothecaPickle Dec 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OothecaPickle Dec 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PikachuEXE Dec 3, 2024

Choose a reason for hiding this comment

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 2, 2024

Uh oh!

OothecaPickle commented Dec 2, 2024

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 2, 2024

Uh oh!

Uh oh!

PikachuEXE Dec 3, 2024

Choose a reason for hiding this comment

Uh oh!

PikachuEXE commented Dec 3, 2024

Uh oh!

PikachuEXE left a comment

Choose a reason for hiding this comment

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented May 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OothecaPickle commented Nov 29, 2024 •

edited

Loading

OothecaPickle commented Nov 29, 2024 •

edited

Loading

OothecaPickle Dec 1, 2024 •

edited

Loading

OothecaPickle Dec 1, 2024 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc Dec 2, 2024 •

edited

Loading