Fix auto-generated RTL captions position#6314
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Dec 9, 2024
Merged
Fix auto-generated RTL captions position#6314FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 9, 2024
kommunarr
approved these changes
Dec 9, 2024
ChunkyProgrammer
approved these changes
Dec 9, 2024
github-actions
bot
removed
the
PR: waiting for review
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
OothecaPickle
pushed a commit
to OothecaPickle/FreeTube
that referenced
this pull request
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix auto-generated RTL captions position
Pull Request Type
Related issue
Description
Just like with the auto-generated captions for left-to-right languages YouTube also adds horizontal positioning to their auto-generated captions for right-to-left captions, however they use 100% (right side of captions area) instead of 0% (left side of captions area) so it wasn't getting caught by the existing logic to remove that positioning.
Screenshots
Before (screenshot taken from the linked issue):
After:
Testing
Arabic (auto-generated)subtitle trackDesktop