Skip to content

Add support for upcoming livestream trailers#6375

Merged
FreeTubeBot merged 4 commits intoFreeTubeApp:developmentfrom
ChunkyProgrammer:add-support-for-upcoming-livestream-trailers
Apr 17, 2025
Merged

Add support for upcoming livestream trailers#6375
FreeTubeBot merged 4 commits intoFreeTubeApp:developmentfrom
ChunkyProgrammer:add-support-for-upcoming-livestream-trailers

Conversation

@ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Dec 13, 2024 •
edited by absidue
Loading

Add support for upcoming livestream trailers

Pull Request Type

  • Feature Implementation

Related issue

LuanRT/YouTube.js#842

Description

This will be difficult to test but some upcoming videos have trailers to view before the stream is uploaded. For example, this is an upcoming video that has a trailer: https://youtu.be/t28qkILDe58 (it will most likely be uploaded by the time this PR gets reviewed).

Screenshots

Upcoming video with trailer:
image

Upcoming video without trailer:
image

Other video (movie) with trailer:
image

Testing

upcoming video with a trailer: https://youtu.be/ari1XFUw73w

  • kinda difficult, find an upcoming live stream that has a trailer associated with it and go to the watch page
  • find an upcoming live stream that doesn't have a trailer associated with it and go to the watch page
  • find a movie that has a trailer associated with it and go to the watch page

Desktop

  • OS: Fedore Linux
  • OS Version: 41 KDE
  • FreeTube version: 0.22.x (latest nightly)

absidue
absidue reviewed Dec 13, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from df57f37 to d35f4a4 Compare January 9, 2025 16:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

absidue
absidue reviewed Jan 9, 2025
View reviewed changes
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from d35f4a4 to 6d8e7f8 Compare January 20, 2025 14:46
This was referenced Jan 21, 2025
Closed
Merged
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from a547596 to be1663d Compare January 21, 2025 13:21
@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Jan 21, 2025

Having trouble finding other upcoming videos with trailers so I'll leave this as a draft for now (also it looks like the trailer was removed from the test video?)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from be1663d to 0db38f7 Compare February 10, 2025 18:34
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 10, 2025

Wait a sec...upstream merged and released a while ago. Any reason for this to be in draft?

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Feb 10, 2025 •
edited
Loading

Wait a sec...upstream merged and released a while ago. Any reason for this to be in draft?

I haven't found another video to test with so I left it in draft

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from 0db38f7 to 587dadc Compare February 20, 2025 15:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Feb 26, 2025

haven't found any other videos like this and the video I found that had this no longer has a trailer it seems.

@absidue absidue reopened this Apr 17, 2025
@absidue absidue force-pushed the add-support-for-upcoming-livestream-trailers branch from 587dadc to 69fa31d Compare April 17, 2025 19:17
@absidue
Copy link
Member

absidue commented Apr 17, 2025

@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE Reviving this as we have a new an upcoming video with a trailer so we can test this. Please review at your earliest convenience (the video in question will premiere in about 16 hours).

https://youtu.be/ari1XFUw73w

@absidue absidue marked this pull request as ready for review April 17, 2025 19:21
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) April 17, 2025 19:21
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 17, 2025
absidue
absidue previously approved these changes Apr 17, 2025
View reviewed changes
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChunkyProgrammer and @absidue !!

PikachuEXE
PikachuEXE approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this with https://youtu.be/ari1XFUw73w
image

@FreeTubeBot FreeTubeBot merged commit c7807fc into FreeTubeApp:development Apr 17, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 17, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Apr 19, 2025
@PikachuEXE
Merge branch 'sabr' into custom-builds/tmp
700c108 
* sabr:
  Log data when protobuf encoding fails
  Translated using Weblate (Greek)
  Add support for upcoming livestream trailers (FreeTubeApp#6375)
  Translated using Weblate (Spanish (Argentina))
  Translated using Weblate (Dutch)
  Translated using Weblate (Spanish (Mexico))
  Translated using Weblate (Spanish (Argentina))
  Translated using Weblate (Spanish (Argentina))
  Translated using Weblate (Norwegian Bokmål)
@absidue absidue mentioned this pull request Apr 19, 2025
Merged
1 task
@ChunkyProgrammer ChunkyProgrammer deleted the add-support-for-upcoming-livestream-trailers branch April 24, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Upcoming video throws TypeError: Cannot read properties of undefined (reading 'player_response')

5 participants

@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @PikachuEXE @FreeTubeBot