Only create the VR canvas when it is required

[absidue]

Only create the VR canvas when it is required

Pull Request Type

• Bugfix

Related issue

• closes [Bug]: Canvas randomly crashes/doesn't load, causing white video player #6530

Description

I don't personally have the problem mentioned in the issue or any way to reproduce it, so I can't test if it actually helps in the situation described by the user, however as they mentioned that removing the canvas helped, this PR should improve the situation. This PR only creates the VR canvas when we actually need it, so for VR videos that have equirectangular projection, other projections are not supported by shaka-player.

I've speculated on what the problem could be in a comment here if you would like to read it: #6530 (comment) (TL;DR likely some miscomunication between graphics drivers and Chromium, that Chromium doesn't handle well).

Testing

• Check that supported VR videos still work correctly e.g. https://youtu.be/H9r8CTsSf4U
• Check with the devtools that the canvas isn't created for normal videos e.g. https://youtu.be/jNQXAC9IVRw and unsupported VR videos e.g. https://youtu.be/h51S8Os7M2Q. You can either check in the element picker or run document.querySelector('canvas') in the devtools console, if it returns null the canvas doesn't exist.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: 85cec5c