Add Creative Commons License to Description of Videos#6614
Add Creative Commons License to Description of Videos#6614FreeTubeBot merged 3 commits intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Please do not skip some of the PR template especially the testing part
Example videos:
https://youtube.com/playlist?list=PLPDjhzarwzCi_nKnIKGyX-nqUZDaeElnB
Sorry I thought the screenshots section is enough for the testing part. I've just tested on different screen sizes as well as a video without the CC license and uploaded the screenshot above |
|
Is it possible to make this part of the description like on YT. I dont like the current placement. |
Head branch was pushed to by a user without write access
Done; now it is in the description like so,
|
Head branch was pushed to by a user without write access
SudharakaP
force-pushed
the
feat/add-cc-license
branch
from
75000be to
15c447b
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
License shouldnt show up in the preview
How the PR handles it:
VirtualBoxVM_mts39BDdtg.mp4
How YT does it:
VirtualBoxVM_y9CTHvpXgT.mp4
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
SudharakaP
force-pushed
the
feat/add-cc-license
branch
from
f358fe6 to
5d523bd
Compare
@efb4f5ff-1298-471a-8973-3d47447115dc : Makes senses and I just changed this to the behaviour you suggested. I initially did the other way intentionally as I though that was a bit better given that within the description the license is much harder to see. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
github-actions
bot
removed
the
PR: waiting for review
* development: Translated using Weblate (Indonesian) Bump version number to v0.23.1 Translated using Weblate (Portuguese (Brazil)) Fix comment sorting when sort by newest is the default (FreeTubeApp#6702) ! Fix license data reading code causing some videos cannot be played (FreeTubeApp#6682) Translated using Weblate (Spanish) Update release.yml Update release.yml Bump version number to v0.23.0 Add Creative Commons License to Description of Videos (FreeTubeApp#6614) Only refresh current trending tab (FreeTubeApp#6667) Translated using Weblate (Icelandic) Translated using Weblate (Chinese (Traditional Han script)) Translated using Weblate (Arabic)
6 participants
Title
Pull Request Type
Related issue
Closes #6600
Description
Add Creative Commons License to Description of Videos. In this PR it just shows the CC license if the license exists or nothing if it's standard YouTube license creating the exact same behaviour of the YouTube app. One thing we can improve is to add a link to the CC license (at, https://creativecommons.org/licenses/by/3.0/legalcode) but I thought to keep this initial PR simple by just adding the license text.
Add creative common license text to the video description if the video is licensed under creative commons.
Screenshots
Testing
Screenshot on Different Device Sizes with a Video with CC
Screenshot of a video without CC license