Skip to content

Add icons to page headers + subscription tabs#6669

Merged
FreeTubeBot merged 6 commits intoFreeTubeApp:developmentfrom
ChunkyProgrammer:add-icons-to-page-headers
Feb 23, 2025
Merged

Add icons to page headers + subscription tabs#6669
FreeTubeBot merged 6 commits intoFreeTubeApp:developmentfrom
ChunkyProgrammer:add-icons-to-page-headers

Conversation

@ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Jan 30, 2025 •
edited by absidue
Loading

Add icons to page headers + subscription tabs

Pull Request Type

  • Feature Implementation

Related issue

closes #6267

Description

Adds icons to page headers when it makes sense to do so + adds some icons to subscription tabs (similar to trending tabs)

Screenshots

image
image
image
image
image
image

Testing

  • go to pages: subscriptions, subscribed channels, settings, user playlists, history, about (Most Popular was updated as well but I'm not aware of any public instances with api enabled + most popular enabled)
  • see new icons

Desktop

  • OS: Fedore Linux
  • OS Version: 41 KDE
  • FreeTube version: latest nightly

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 30, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 30, 2025 18:55
@ChunkyProgrammer ChunkyProgrammer changed the title Add icons to page headers Add icons to page headers + subscription tabs Jan 30, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 30, 2025

Most Popular icon is white instead of based on the color that is defined in the settings

VirtualBoxVM_scoEvHHjv1.mp4

@absidue
Copy link
Member

absidue commented Jan 30, 2025 •
edited
Loading

On mobile the settings menu looks odd with the icon in the title, as other than a minor text colour difference it now looks the same as the labels for the sections. It might be worth removing the icon on the settings page to avoid confusion.

I also noticed that no icon was added for the search results page.

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 30, 2025
@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Jan 30, 2025 •
edited
Loading

On mobile the settings menu looks odd with the icon in the title, as other than a minor text colour difference it now looks the same as the labels for the sections. It might be worth removing the icon on the settings page to avoid confusion.

I also noticed that no icon was added for the search results page.

On mobile the settings menu looks odd with the icon in the title, as other than a minor text colour difference it now looks the same as the labels for the sections. It might be worth removing the icon on the settings page to avoid confusion.

I also noticed that no icon was added for the search results page.

I've updated it to hide the icon on the settings page on mobile and added an icon for the search results page

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jan 30, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 30, 2025

Should there also be an icon here? Im not sure tbh.

VirtualBoxVM_hlyT7lZpc3.mp4

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Feb 2, 2025

Should there also be an icon here? Im not sure tbh.
VirtualBoxVM_hlyT7lZpc3.mp4

It would look like this:
image

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-icons-to-page-headers branch from 3b03f51 to 9679004 Compare February 2, 2025 03:50
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 2, 2025

idk if you should go for that for the sake of consistency or if we shouldn't do it because it would look weird. I need the others to chime in on this one

@PikachuEXE
Copy link
Member

PikachuEXE commented Feb 3, 2025

I am fine with having icon on hash tag page
Doesn't look weird to me

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 4, 2025

@PikachuEXE the icon always has been there. The subject is more if we should make that icon be based on the primary color theme like other icons

@PikachuEXE
Copy link
Member

PikachuEXE commented Feb 5, 2025

Looks fine in my usual theme but not sure about the other themes

@absidue
Copy link
Member

absidue commented Feb 10, 2025

I like the coloured hashtag icon.

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Feb 11, 2025

Implemented the hashtag icon with color

PikachuEXE
PikachuEXE previously approved these changes Feb 12, 2025
View reviewed changes
absidue
absidue reviewed Feb 20, 2025
View reviewed changes
@ChunkyProgrammer ChunkyProgrammer marked this pull request as draft February 20, 2025 13:04
auto-merge was automatically disabled February 20, 2025 13:04

Pull request was converted to draft

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 20, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 20, 2025

Marked as draft by accident?

@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review February 20, 2025 14:42
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 20, 2025 14:42
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 20, 2025
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-icons-to-page-headers branch from af5d3b9 to 641da96 Compare February 20, 2025 14:45
@FreeTubeBot FreeTubeBot merged commit 2f53c9d into FreeTubeApp:development Feb 23, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 23, 2025
doublecrow pushed a commit to doublecrow/FreeTube that referenced this pull request Mar 28, 2025
@ChunkyProgrammer @absidue @doublecrow
Add icons to page headers + subscription tabs (FreeTubeApp#6669)
92a26a6 
* Add icons to page headers

* fix most popular page

* Add icon to search page, hide settings icon on mobile

* use icon for hashtag as well

* Fix getting invidious hashtag

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

* fix bug when fetching more hashtag in invidious, use hashtag ref instead of a paremeter

---------

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
@ChunkyProgrammer ChunkyProgrammer deleted the add-icons-to-page-headers branch April 24, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add an respective icon to the title of every tab

5 participants

@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @PikachuEXE @FreeTubeBot