Change the release workflow to accept the release ID as an input#6751
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Feb 5, 2025
Merged
Change the release workflow to accept the release ID as an input#6751FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
Member
|
Should this be merged into master instead? |
Member
Author
|
This pull request no, if we do that then the branches will get out of sync. I can however create a second pull request that goes into the master branch if we don't want to wait until the next release to do it. In my mind the development branch is the source of truth and the master branch just contains snapshots of the development branch. |
ChunkyProgrammer
approved these changes
Feb 5, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 5, 2025
kommunarr
approved these changes
Feb 5, 2025
github-actions
bot
removed
the
PR: waiting for review
absidue
added a commit
to absidue/FreeTube
that referenced
this pull request
Feb 10, 2025
1 task
efb4f5ff-1298-471a-8973-3d47447115dc
added a commit
that referenced
this pull request
Feb 11, 2025
Cherry pick: Change the release workflow to accept the release ID as an input (#6751)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the release workflow to accept the release ID as an input
Pull Request Type
Description
Currently the release workflow takes the release ID out of a repository secret. As editing the repository secrets is a cumbersome process I decided to use a workflow input instead, that way you can just paste it into a text box before pressing the
Run workflowbutton right below it.https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch
Screenshots
Desktop