Implement content and session PO tokens#6931
Implement content and session PO tokens#6931FreeTubeBot merged 4 commits intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
|
Putting into custom build to test for 1 week+ |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
|
I don't experience this bug in my regular usage but will start testing this build. |
This comment has been minimized.
This comment has been minimized.
|
@ArthurKun21 That build is based on the older commits that were using a hardcoded timeout which is no longer present in the latest commits. If you want to help test PRs, please make sure you are actually using the latest changes next time before commenting that something doesn't work for you. |
|
2nd 403 in a short period of testing and i cant replicate this behavior at all on the nightly build which im almost using daily
|
|
I got several 403 but not frequently and I did not use normal build for a while so no idea if YT doing stuff or this PR causing it |
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
LGTM, i think i forced the 403's by switching to the next video over and over again at the speed of light
github-actions
bot
removed
the
PR: waiting for review
* development: Translated using Weblate (English (United Kingdom)) Bump electron from 35.0.1 to 35.0.2 (FreeTubeApp#7020) Bump @babel/core from 7.26.9 to 7.26.10 in the babel group (FreeTubeApp#7017) Bump eslint-plugin-jsdoc from 50.6.3 to 50.6.6 in the eslint group (FreeTubeApp#7019) Implement content and session PO tokens (FreeTubeApp#6931) Bump stylelint from 16.15.0 to 16.16.0 in the stylelint group (FreeTubeApp#7018) Translated using Weblate (Icelandic) Translated using Weblate (Persian) Translated using Weblate (French) Translated using Weblate (Bulgarian) Translated using Weblate (Polish) Translated using Weblate (Turkish) Translated using Weblate (Serbian) Translated using Weblate (Italian) Translated using Weblate (French)
* Implement content and session PO tokens * Remove timeout after BgUtils update * Trigger GitHub CI
* Implement content and session PO tokens * Remove timeout after BgUtils update * Trigger GitHub CI
7 participants
Implement content and session PO tokens
Pull Request Type
Related issue
Will link it after other devs have confirmed that it solves the issue for them too.
Description
YouTube has switched from just using session based PO tokens that are added to the streaming URLs, which is what we are currently doing, to also introducing content PO tokens which are tied to the video ID added to the
/playerrequest. This pull request implements that new PO token. Challenges are now fetched from thehttps://www.youtube.com/api/jnnwhich is a proxy forjnn-pa.googleapis.cominstead of fetching it directly from the latter URL, which should hopefully help with people's misconfiguring their ad-blocker to blockjnn-pa.googleapis.com.This will definitely have code conflicts with the potoken proxy pull request, I will resolve the code conflicts in whichever pull request is merged later.
Testing
Open various videos and check that you don't get any 403s or
Error: Error invoking remote method 'generate-po-token'errors.Desktop