Increase PO token snapshot timeout from 3 to 10 seconds#7114
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Apr 7, 2025
Merged
Increase PO token snapshot timeout from 3 to 10 seconds#7114FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 30, 2025
PikachuEXE
approved these changes
Mar 31, 2025
Member
ChunkyProgrammer
approved these changes
Apr 7, 2025
github-actions
bot
removed
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube
that referenced
this pull request
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase PO token snapshot timeout from 3 to 10 seconds
Pull Request Type
Related issue
Description
By default bgutils-js times out the snapshot method after 3 seconds to avoid it blocking forever in case something goes wrong, however it seems like some of our users have encountered legitimate scenarios where the snapshot method will run longer than 3 seconds. In the linked issue one user was running the x64 build of FreeTube on an arm64 Mac, so the translation overhead likely resulted in FreeTube running slower.
Testing
While I haven't personally encountered a timeout from the snapshot method, I decided that jumping to 10 seconds should give it enough time even on slower setups while still achieving the goal of preventing it from blocking forever.
Desktop