Support LockupView videos in the up next feed#7186
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Apr 20, 2025
Merged
Support LockupView videos in the up next feed#7186FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 11, 2025
Member
|
All other trailers work fine bit
|
Member
Author
|
Seems to be an error in the player, so unrelated but definitely weird. |
ChunkyProgrammer
approved these changes
Apr 20, 2025
PikachuEXE
approved these changes
Apr 20, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 20, 2025
* development: Support LockupView videos in the up next feed (FreeTubeApp#7186)
7 tasks
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube
that referenced
this pull request
Jul 12, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support LockupView videos in the up next feed
Pull Request Type
Related issue
Surprisingly nobody has reported this yet
Description
This pull request fixes the up next feed occasionally being empty, by adding support for
VIDEOLockupViews and also fixes movies not being parsed correctly (their video ID was being set to undefined, which meant the thumbnail didn't appear and clicking on it produced an error). This doesn't currently support upcoming videos as I wasn't able to find an example of one appearing in the up next feed.Screenshots
Before with LockupViews
After with LockupViews
Before with CompactMovies
After with CompactMovies
Testing
LockupViews appearing in the up next feed still seems to be somewhat random, so that isn't the easiest thing to test but testing the movie parsing changes is doable as you just need to find a YouTube Movie (they usually only have YouTube movies in their up next lists).
Desktop