Skip to content

Update electron-builder to latest pre-release version#7206

Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
PikachuEXE:update/electron-builder
Apr 20, 2025
Merged

Update electron-builder to latest pre-release version#7206
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
PikachuEXE:update/electron-builder

Conversation

@PikachuEXE
Copy link
Member

@PikachuEXE PikachuEXE commented Apr 15, 2025

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Should close #6691

Description

To include fix in electron-userland/electron-builder#9007

Screenshots

What I got after this PR on macOS 13 (expected case
image

Testing

Custom build for this PR: https://github.com/PikachuEXE/FreeTube/actions/runs/14458340009

A. Not macOS

  • Just download the build and it should run

B. macOS

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 15, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) April 15, 2025 00:16
@efb4f5ff-1298-471a-8973-3d47447115dc

According to the upstream screenshot it should say Done but in yours it says Show in finder. Hows that possible?

@PikachuEXE
Copy link
Member Author

Different OS version I guess (or diff machine type? doubt
My OS screen looks like
image

In electron-userland/electron-builder#9007 it looks like
image

So as long as user can launch the app after that screen in OS settings then it should be fine

@kthchew
Copy link

kthchew commented Apr 15, 2025

According to the upstream screenshot it should say Done but in yours it says Show in finder. Hows that possible?

I believe the warning looked like that in macOS 14. In macOS 15 it looks like it does in the upstream screenshot. In either case the warning should be bypassable in the GUI (in macOS 14 you can either do the right click -> open trick or go to System Settings, and in macOS 15 you must go to System Settings).

@FreeTubeBot FreeTubeBot merged commit 02a3acf into FreeTubeApp:development Apr 20, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 20, 2025
@PikachuEXE PikachuEXE deleted the update/electron-builder branch June 2, 2025 01:13
efb4f5ff-1298-471a-8973-3d47447115dc pushed a commit to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Mac arm64 version broken

6 participants