Skip to content

Fix parsing grid channels without a subscriber count#7486

Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
absidue:grid-channel-subscribers
May 30, 2025
Merged

Fix parsing grid channels without a subscriber count#7486
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
absidue:grid-channel-subscribers

Conversation

@absidue
Copy link
Member

@absidue absidue commented May 29, 2025

Pull Request Type

  • Bugfix

Related issue

Description

This pull request fixes the error when the subscriber count is missing for GridChannel nodes and an extra bug I noticed where the video count wasn't showing up.

Screenshots

After parsing fix:
parsing-fix

After video count fix:
videos-fix

Testing

  1. Open https://www.youtube.com/channel/UCD_2nYVTpyaLeF6r83vCrJw
  2. Check that the error log is gone and that the home page shows up.
  3. Scroll down to the "Featured Channels" section and check that the video count shows up for both channels and the subscriber count only for the "GRM Daily" channel.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 45ecc6b

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 29, 2025 22:26
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 29, 2025
@FreeTubeBot FreeTubeBot merged commit 9bfdc97 into FreeTubeApp:development May 30, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 30, 2025
@absidue absidue deleted the grid-channel-subscribers branch May 30, 2025 05:40
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request May 31, 2025
…rrent

* fix/open-input-url-in-new-window:
  ! Fix opening URL in a new window restores main window (in Windows)
  Translated using Weblate (Danish)
  Translated using Weblate (Japanese)
  Fix parsing grid channels without a subscriber count (FreeTubeApp#7486)
  Local API: Add PO tokens to the caption URLs (FreeTubeApp#7484)
  Add preload script and disable node integration in renderer processes (FreeTubeApp#7424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Home tab - TypeError: Cannot read properties of undefined (reading 'match')

5 participants