Fix variant selection when no variant's audio role marked as main#7571
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Jun 17, 2025
Merged
Conversation
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
force-pushed
the
fix/no-main-audio-track-fallback
branch
from
365d2ee to
6acf30c
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 17, 2025
absidue
approved these changes
Jun 17, 2025
ChunkyProgrammer
approved these changes
Jun 17, 2025
github-actions
bot
removed
the
PR: waiting for review
|
Thanks ❤️ |
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 23, 2025
* development: (214 commits) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (French) Translated using Weblate (French) add search filter reset button (FreeTubeApp#7531) ! Fix variant selection when no variant's audio role marked as main (FreeTubeApp#7571) Make sure description isn't null when extracting chapters from description (FreeTubeApp#7505) Translated using Weblate (French) Bump stefanzweifel/git-auto-commit-action from 5 to 6 (FreeTubeApp#7564) Translated using Weblate (Swedish) Bump the eslint group with 3 updates (FreeTubeApp#7567) Bump sass from 1.89.1 to 1.89.2 (FreeTubeApp#7565) Bump shaka-player from 4.14.15 to 4.14.18 (FreeTubeApp#7566) Bump postcss from 8.5.4 to 8.5.5 in the stylelint group (FreeTubeApp#7568) Bump electron-builder from 26.0.16 to 26.0.17 (FreeTubeApp#7569) Translated using Weblate (English (United Kingdom)) add beta to asset name (FreeTubeApp#7512) Translated using Weblate (Dutch) Translated using Weblate (Dutch) Fix builds failing due to broken Weblate keys (FreeTubeApp#7560) Translated using Weblate (Persian) ... # Conflicts: # package.json # src/renderer/helpers/api/local.js
|
Would it be possible to reopen the #7435 again, still experiencing the bug even on the nightly 6130, unfortunately I didn't managed to open the dev tools I forgot |
Member
|
Please provide urls |
|
it was random, last I saw the error was with this video https://youtu.be/FzLABAppJfM |
|
Nightly 6152 |
Member
Author
|
Your error with prefix WEBM is what I reported and is related to Chromium version
|
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube
that referenced
this pull request
Jul 12, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #7435
Description
Error caused by certain videos like https://youtu.be/PZJCBd_DhfE from #7435
Where no variant got audio role
mainso the filtered variants is empty and reading stuff from the first one = errorThis PR makes it to NOT filter variants if no
mainaudio role variant foundScreenshots
Testing
Desktop
Additional context