Skip to content

Fix subtitles being in the top right corner#7841

Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
absidue:subtitle-position
Aug 12, 2025
Merged

Fix subtitles being in the top right corner#7841
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
absidue:subtitle-position

Conversation

@absidue
Copy link
Member

@absidue absidue commented Aug 11, 2025

Pull Request Type

  • Bugfix

Related issue

Description

This pull request fixes the recent issue with uploader provided subtitles being positioned in the top right corner of the video player.

Screenshots

Before: see screenshots in the linked thread
After: the way it used to be, so I hopefully don't need to take a screenshot of it for you.

Testing

Test that uploader provided subtitles are in their correct position in the bottom middle of the video player.
E.g. "English" on this video https://youtu.be/nMfYXqXt8mE

Desktop

  • OS: Windows
  • OS Version: 10

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 11, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 11, 2025 16:47
@FreeTubeBot FreeTubeBot merged commit a6fb5d8 into FreeTubeApp:development Aug 12, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 12, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 12, 2025
* development:
  Set checkForBlogPosts to false (FreeTubeApp#7840)
  Fix subtitles being in the top right corner (FreeTubeApp#7841)
  Translated using Weblate (Swedish)
  Bump electron from 37.2.5 to 37.2.6 (FreeTubeApp#7833)
  Bump sass from 1.89.2 to 1.90.0 (FreeTubeApp#7834)
  Bump the eslint group with 3 updates (FreeTubeApp#7836)
  Bump shaka-player from 4.14.25 to 4.14.26 (FreeTubeApp#7838)
  Bump mini-css-extract-plugin from 2.9.2 to 2.9.3 (FreeTubeApp#7839)
  Translated using Weblate (Basque)
@absidue absidue deleted the subtitle-position branch August 12, 2025 03:51
efb4f5ff-1298-471a-8973-3d47447115dc pushed a commit to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants