Add error handling to the deciphering code#8139
Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom Oct 15, 2025
Merged
Add error handling to the deciphering code#8139FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
1 task
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 15, 2025
PikachuEXE
approved these changes
Oct 15, 2025
ChunkyProgrammer
approved these changes
Oct 15, 2025
github-actions
bot
removed
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube
that referenced
this pull request
Oct 15, 2025
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 16, 2025
* development: Bump package version from 0.23.11 to 0.23.12 (FreeTubeApp#8138) Add error handling to the deciphering code (FreeTubeApp#8139) Fix video playback by using video ID bound poToken (FreeTubeApp#8137) Hide subscriptions wrapper on mobile and center bottom SideNav items (FreeTubeApp#8133) ! Fix sigFrameScript on dev in windows (FreeTubeApp#8134) Translated using Weblate (Estonian) Bump github/codeql-action from 3 to 4 (FreeTubeApp#8124) Translated using Weblate (Welsh) Bump mikefarah/yq from 4.47.2 to 4.48.1 (FreeTubeApp#8123) Bump stefanzweifel/git-auto-commit-action from 6 to 7 (FreeTubeApp#8125) Bump package version from 0.23.10 to 0.23.11 (FreeTubeApp#8126) # Conflicts: # src/renderer/helpers/api/local.js
PikachuEXE
added a commit
to NishPatel101/FreeTube
that referenced
this pull request
Oct 21, 2025
* development: (88 commits) Bump the eslint group with 4 updates (FreeTubeApp#8158) Translated using Weblate (German) Bump shaka-player from 4.16.4 to 4.16.6 (FreeTubeApp#8167) Bump marked from 16.4.0 to 16.4.1 (FreeTubeApp#8159) Bump electron from 38.2.2 to 38.3.0 (FreeTubeApp#8161) Bump actions/setup-node from 5 to 6 (FreeTubeApp#8162) Bump youtubei.js from 16.0.0 to 16.0.1 (FreeTubeApp#8163) Translated using Weblate (Persian) Translated using Weblate (Czech) Translated using Weblate (Bulgarian) Add missing IS_ELECTRON and SUPPORTS_LOCAL_API checks (FreeTubeApp#8147) Simplify the NATIVE_THEME_UPDATE event handler (FreeTubeApp#8140) Bump package version from 0.23.11 to 0.23.12 (FreeTubeApp#8138) Add error handling to the deciphering code (FreeTubeApp#8139) Fix video playback by using video ID bound poToken (FreeTubeApp#8137) Hide subscriptions wrapper on mobile and center bottom SideNav items (FreeTubeApp#8133) ! Fix sigFrameScript on dev in windows (FreeTubeApp#8134) Translated using Weblate (Estonian) Bump github/codeql-action from 3 to 4 (FreeTubeApp#8124) Translated using Weblate (Welsh) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This pull request adds a try-catch handler to the deciphering code inspired by what @MarmadileManteater did in FreeTubeAndroid. I also added some
IS_ELECTRONguards in the same places that they were added in FreeTubeAndroid now that we know that we can't use the same deciphering implemenation for both Electron and Android.Testing
Test that videos play/this didn't break things.
Desktop