Add a show all windows button to the tray menu#8494
Add a show all windows button to the tray menu#8494FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
|
rip i cant properly test this in my Ubuntu VM due to #8359 :/ |
|
I tested this on Windows via https://github.com/PikachuEXE/FreeTube/actions/runs/20767925766 |
|
Tested it too with your build and seems to be working perfectly. I have one maybe nitpick point of discussion. My first minimized window is the last to be unminimized and my last minimized window is the first one that will show. Should we maybe change it to the other way around so the first window that is minimized is the first to show? The current approach is very logical from the point that it was the user's last opened window to show first but i thought to raise the point anyway. I think the current approach is good as is |
|
I have no preference here coz I don't use it :P |
|
I don't mind either way, I van reverse it if you would prefer that? |
|
No i think its good but i only raised it just in case both of you wanted to see it changed |
github-actions
bot
removed
the
PR: waiting for review
* development: (55 commits) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Czech) Translated using Weblate (Russian) Translated using Weblate (Polish) Translated using Weblate (Kurdish (Central)) Translated using Weblate (French) Use GITHUB_TOKEN instead of dedicated PUSH_TOKEN in auto-merge workflow (FreeTubeApp#8541) Local API: Implement SABR for VODs (FreeTubeApp#8047) Bump package version from 0.23.12 to 0.23.13 (FreeTubeApp#8531) Update CodeQL workflow to match the latest template (FreeTubeApp#8533) fix: video player playback rate (FreeTubeApp#8407) Decipher live DASH manifest URL (FreeTubeApp#8530) Add a show all windows button to the tray menu (FreeTubeApp#8494) Disable automatically running the flatpak workflow (FreeTubeApp#8507) fix using shift on watch page (FreeTubeApp#8491) Translated using Weblate (Hebrew) Translated using Weblate (Hebrew) Fix WAPT link in README (FreeTubeApp#8529) Fix typo in auto-merge workflow (FreeTubeApp#8518) Added translation using Weblate (Uzbek) ...
5 participants
Pull Request Type
Related issue
Description
This pull request adds a show all windows button to the tray menu, which does what it says on the tin: shows all hidden windows.
Testing
The tray menu is only implemented on Windows and Linux
Desktop