Add support for Wayland IMEs#8570
Closed
Arthur-Huan wants to merge 1 commit intoFreeTubeApp:developmentfrom
Closed
Add support for Wayland IMEs#8570Arthur-Huan wants to merge 1 commit intoFreeTubeApp:developmentfrom
Arthur-Huan wants to merge 1 commit intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
Arthur-Huan
changed the title
Member
|
You wrote "hopefully closes" does that mean you didn't actually test this pull request? |
absidue
added
U: Waiting for Response from Author
and removed
PR: waiting for review
Author
|
Sorry for the misunderstanding. I tested it on KDE Plasma with fcitx5, Maliit, and IBus, and on GNOME with IBus. I just didn't feel confident in saying it definitively solves the issue for every DE and IME combo. |
Member
|
@Arthur-Huan If I am reading the Chromium source code correctly wayland IME support should already be enabled by default in the Electron version that the development branch is using (the development branch is way ahead of the 0.23.x releases) via the text-input-v3 protocol. Could you please test the development branch without this change and see if IME still works? References: |
Author
|
I believe you are correct, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Hopefully closes #8272 and #6950
Description
Add the
--enable-wayland-imeflag to tell Electron to use the Wayland IME pathway if on Wayland.Testing
Additional context
Applying the
--enable-wayland-imeflag seems to be the current solution for the upstream issue, but this may become deprecated or unnecessary if/when Electron implements it by default.