Remove unnecessary jq --binary arg in build workflow#8619
Merged
FreeTubeBot merged 1 commit intodevelopmentfrom Feb 3, 2026
Merged
Remove unnecessary jq --binary arg in build workflow#8619FreeTubeBot merged 1 commit intodevelopmentfrom
FreeTubeBot merged 1 commit intodevelopmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 3, 2026
ChunkyProgrammer
approved these changes
Feb 3, 2026
PikachuEXE
approved these changes
Feb 3, 2026
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This fixes the build workflow failing on the Ubuntu runners.
I originally added the
--binaryflag to thejqcall to makejqoutput the line endings as LF (\n) instead of CRLF (\r\n) on Windows but as we don't change the Git settings before cloning the repository the line endings are already getting converted to CRLF by Git for Windows, so it is actually fine ifjqoutputs CRLF.The
--binaryflag was added tojqin 1.7 but only for Windows, in 1.8 they added no-op support for that flag on Linux and macOS. Unlike the Windows and macOS runners that use the latestjqversion, the Ubuntu runners use thejqversion from the Ubuntu repositories so are stuck onjq1.7.Links:
--binaryon non-Windows platforms jqlang/jq#3131Testing