Skip to content

Fix the proxy test by stripping the request headers#8704

Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
absidue:fix-proxy-test
Mar 5, 2026
Merged

Fix the proxy test by stripping the request headers#8704
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
absidue:fix-proxy-test

Conversation

@absidue
Copy link
Member

@absidue absidue commented Feb 21, 2026

Pull Request Type

  • Bugfix

Related issue

Description

The API we are using for the proxy test button added CORS protection, this pull request strips the request headers from the requests to that API so that the requests still go through.

Testing

I added this patch to the src/renderer/components/ProxySettings/ProxySettings.vue component to force it to show the proxy test button even when a proxy is not configured and clicked the proxy test button.

diff --git a/src/renderer/components/ProxySettings/ProxySettings.vue b/src/renderer/components/ProxySettings/ProxySettings.vue
index 84749afc9..ab34818b4 100644
--- a/src/renderer/components/ProxySettings/ProxySettings.vue
+++ b/src/renderer/components/ProxySettings/ProxySettings.vue
@@ -20,7 +20,7 @@
       />
     </FtFlexBox>
     <template
-      v-if="useProxy"
+      v-if="true"
     >
       <FtFlexBox>
         <FtSelect
@@ -301,12 +301,6 @@ function disableProxy() {
 }
 
 async function testProxy() {
-  isLoading.value = true
-
-  if (!useProxy.value) {
-    enableProxy()
-  }
-
   try {
     const response = await fetch(proxyTestUrl.value)
     const json = await response.json()
@@ -321,10 +315,6 @@ async function testProxy() {
     showToast(t('Settings.Proxy Settings["Error getting network information. Is your proxy configured properly?"]'))
     dataAvailable.value = false
   } finally {
-    if (!useProxy.value) {
-      disableProxy()
-    }
-
     isLoading.value = false
   }
 }

Desktop

  • OS: Windows
  • OS Version: 11

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 21, 2026 21:37
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 21, 2026
@FreeTubeBot FreeTubeBot merged commit 183c4b2 into FreeTubeApp:development Mar 5, 2026
6 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 5, 2026
@absidue absidue deleted the fix-proxy-test branch March 5, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Proxy test endpoint ipwho.is not available

5 participants