Skip to content

[FEATURE] Add Ghost Tapping to the Preferences Menu, and an option to center the strumline#2564

Closed
xmb9 wants to merge 8 commits into
FunkinCrew:mainfrom
xmb9:main
Closed

[FEATURE] Add Ghost Tapping to the Preferences Menu, and an option to center the strumline#2564
xmb9 wants to merge 8 commits into
FunkinCrew:mainfrom
xmb9:main

Conversation

@xmb9
Copy link
Copy Markdown
Contributor

@xmb9 xmb9 commented May 19, 2024

image
image

This is a follow up to my original pull request that fixed the strumline offset so it was no longer off center, I noticed that ghost tapping support was toggle-able from the source code so I also added an option for that too.

@charlesisfeline
Copy link
Copy Markdown
Contributor

but they didnt want ghost tapping to be in anyone's hands, its all about difficulty, why dont you just make your own engine at that point

@xmb9
Copy link
Copy Markdown
Contributor Author

xmb9 commented May 20, 2024

but they didnt want ghost tapping to be in anyone's hands, its all about difficulty, why dont you just make your own engine at that point

I'm not THAT knowledgable lmao

@xmb9
Copy link
Copy Markdown
Contributor Author

xmb9 commented May 20, 2024

Also, where exactly is the proof of your statement?

@xmb9
Copy link
Copy Markdown
Contributor Author

xmb9 commented May 20, 2024

Also, where exactly is the proof of your statement?

PhantomArcade literally said themselves that Ghost Tapping was good...

@xmb9
Copy link
Copy Markdown
Contributor Author

xmb9 commented May 20, 2024

If they didn't want it to be in anyone's hands why would they even make it an option during compilation???

@xmb9 xmb9 changed the title Add Ghost Tapping to the Preferences Menu, and an option to center the strumline [FEATURE] Add Ghost Tapping to the Preferences Menu, and an option to center the strumline May 20, 2024
@EliteMasterEric
Copy link
Copy Markdown
Member

Ghost tapping is an option during compilation because it's been in testing, on and off.

Since this is a nuanced feature which requires a lot of playtesting and tweaking (I was messing around with it earlier and it was NOT behaving in a way I felt was intuitive or fair), it should be definitely implemented by us.

Furthermore, since it's a gameplay change which directly affects how the game performs scoring, it should ABSOLUTELY not be a toggleable option.

Oh yeah, plus the centered strumline is on purpose.

@EliteMasterEric EliteMasterEric added status: rejected Issue did not pass review or PR cannot be approved. and removed wontfix labels Jun 17, 2024
@EliteMasterEric EliteMasterEric added the size: medium A medium pull request with 100 or fewer changes. label May 14, 2025
@Marcosayfi
Copy link
Copy Markdown
Contributor

can't you atleast add the ghostapping from mobile? why do they get ghostapping?

@MightyTheArmiddilo
Copy link
Copy Markdown
Contributor

can't you atleast add the ghostapping from mobile? why do they get ghostapping?

It is significantly easier to accidentally hit the screen on mobile which can lead to unnecessary ghost misses. Also, the ghost tapping isn't exactly perfect yet iirc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: medium A medium pull request with 100 or fewer changes. status: rejected Issue did not pass review or PR cannot be approved.

Development

Successfully merging this pull request may close these issues.

5 participants