Chart Editor - Fix notelay sound playing when not in grid

[amyspark-ng]

Does this PR close any issues? If so, link them below.

Fixes #4153

Briefly describe the issue(s) fixed.

The editor would play notelay even when the cursor was outside the grid

Include any relevant screenshots or videos.

I just realized there's an issue with this LOL, so will keep it as draft for now

[amyspark-ng]

it does seem to work now!, the logic might be a little "faulty" in the sense that i have to "recheck" the change in steps but it works

https://github.com/amyspark-ng/Funkin/blob/4a19dcb9958a3f3087eaec89b81d21cc6f79681f/source/funkin/ui/debug/charting/ChartEditorState.hx#L4568

2025-02-17_13-37-18.mp4

[Lasercar]

it does seem to work now!, the logic might be a little "faulty" in the sense that i have to "recheck" the change in steps but it works

2025-02-17_13-37-18.mp4

Oh, uh, you don’t have to rerun the check like that. Skipping setting the stuff entirely makes more sense, does the same thing and makes the code look much cleaner.

[amyspark-ng]

you mean like if (!overlarpsGrid) return? that changes completely the behavior!

[Lasercar]

Nooo, just this if ((dragTargetCurrentColumn != dragDistanceColumns && overlapsGrid) || dragTargetCurrentStep != dragDistanceSteps)change at 4565, that’s it, rather than where it is now.

Basically, don’t run the note moving stuff if the mouse is outside the grid and the y position isn’t changing.

[amyspark-ng]

ohhh i see what you mean! i will change it right now

nvm, editing code in phone is really hard, give me like an hour

[amyspark-ng]

while checking if the fix worked, i noticed there was a different bug where an event selected won't move properly if it's not the "leader" item selected

this is a whole different issue that i will report rn
the video shows before and after of the issue i fixed, also shows the bug im mentioning

2025-02-17_22-03-04.mp4

[Lasercar]

comment moved to: #4186 (comment)

[amyspark-ng]

i'd like to help on this issue but moving items is actually very hard! i had to do something like this recently and struggled a lot, in fact, if you do understand how it works i'd appreciate an explanation

What i did was when you're selecting a bunch of notes and you click one, that note is now a "leader note" and for every selected note i store the difference to that "leader note", then the leader note will move to the hovered step and every other selected note will move to the same step, but adding the difference, so they keep the respective offset

the issue has been opened #4186

[amyspark-ng]

is this good? can it be merged pretty please

[EliteMasterEric]

Seems like a good change

[amyspark-ng]

im just seeing this now lol, yippee