Skip to content

[ENHANCEMENT] Bring Back Combo Milestone#4700

Closed
anysad wants to merge 1 commit into
FunkinCrew:developfrom
anysad:bring-back-combo
Closed

[ENHANCEMENT] Bring Back Combo Milestone#4700
anysad wants to merge 1 commit into
FunkinCrew:developfrom
anysad:bring-back-combo

Conversation

@anysad
Copy link
Copy Markdown
Contributor

@anysad anysad commented Apr 12, 2025

Requires FunkinCrew/funkin.assets#162 to be merged!

Briefly describe the issue(s) fixed.

  • This PR brings back that one time leaked combo milestone. That's pretty much it.
  • Note: Initially I tried to make it as an option for the NoteStyle for caching and allat, but I almost broke everything, so I might leave this for another folk who has more brains than me.

Include any relevant screenshots or videos.

https://youtu.be/lA2dMGfCprw (8mb.video compressed my video into making it seem like some sort of shitpost)

@github-actions github-actions Bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels Apr 12, 2025
@AbnormalPoof AbnormalPoof added the type: enhancement Involves an enhancement or new feature. label Apr 12, 2025
@EliteMasterEric
Copy link
Copy Markdown
Member

This was intentionally cut, Dave decided it was way too flashy and annoying.

@EliteMasterEric EliteMasterEric added the status: rejected Issue did not pass review or PR cannot be approved. label Apr 12, 2025
@github-actions github-actions Bot removed the status: pending triage Awaiting review. label Apr 12, 2025
@anysad
Copy link
Copy Markdown
Contributor Author

anysad commented Apr 12, 2025

fair enough

@anysad anysad deleted the bring-back-combo branch April 12, 2025 17:30
@Hundrec Hundrec removed type: enhancement Involves an enhancement or new feature. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Apr 13, 2025
@imavie
Copy link
Copy Markdown

imavie commented Apr 14, 2025

maybe make another design :D

@EliteMasterEric EliteMasterEric added the size: medium A medium pull request with 100 or fewer changes. label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: medium A medium pull request with 100 or fewer changes. status: rejected Issue did not pass review or PR cannot be approved.

Development

Successfully merging this pull request may close these issues.

5 participants