[BUGFIX] Prevent crash when missing credits.json with -D NO_HARDCODED_CREDITS#5982
Merged
Hundrec merged 1 commit intoOct 14, 2025
Conversation
github-actions
Bot
added
status: pending triage
AbnormalPoof
added
type: major bug
Hundrec
changed the title
-D NO_HARDCODED_CREDITS-D NO_HARDCODED_CREDITS
AbnormalPoof
added
status: reviewing internally
AbnormalPoof
force-pushed
the
sphis/fix-missing-credits-json
branch
from
6c66fb7 to
7faa626
Compare
AbnormalPoof
added
the
status: reviewing internally
Hundrec
added
status: accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
N/A
Description
When the game is compiled with the flag
-D NO_HARDCODED_CREDITSthe game will crash when trying to enter the credits state because of the missing credits json.This is cause the credits json is in the excludes folder, I mean it would be hardcoded credits so I guess it makes sense? But there isn't any code or checks for un-hardcoded credits.
This PR fixes that.
Screenshots/Videos
Before:
Screen.Recording.2025-09-11.174910.mp4
After:
Screen.Recording.2025-09-11.181030.mp4