Skip to content

[ENHANCEMENT] FPS Independent health icon bopping#6035

Merged
Hundrec merged 2 commits into
FunkinCrew:dummy/develop-v0.7.5from
PurSnake:fps-icons-uhh
Sep 29, 2025
Merged

[ENHANCEMENT] FPS Independent health icon bopping#6035
Hundrec merged 2 commits into
FunkinCrew:dummy/develop-v0.7.5from
PurSnake:fps-icons-uhh

Conversation

@PurSnake
Copy link
Copy Markdown
Contributor

@PurSnake PurSnake commented Sep 16, 2025

Linked Issues

Any issues about FPS Dependent HealthIcons

Description

Now icons use their own tween (bopTween) to bop.
And also the speed of bopping accelerates at high BMP (noticeable at BMP > 190)

@github-actions github-actions Bot added size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. labels Sep 16, 2025
@trayfellow
Copy link
Copy Markdown
Contributor

trayfellow commented Sep 17, 2025

The best day of LeGooey's life.

@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. labels Sep 17, 2025
@Hundrec Hundrec changed the title [BUGFIX] FPS Independent HealthIcons [ENHANCEMENT] FPS Independent HealthIcons Sep 17, 2025
@PurSnake
Copy link
Copy Markdown
Contributor Author

PurSnake commented Sep 17, 2025

Well, enhancement then

@Hundrec Hundrec changed the title [ENHANCEMENT] FPS Independent HealthIcons [ENHANCEMENT] FPS Independent health icon bopping Sep 17, 2025
@AbnormalPoof AbnormalPoof added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Sep 29, 2025
Hundrec
Hundrec requested changes Sep 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, except for one tiny detail that prevents me from approving:

Testing FPS-independent health icons
I can't get a video right now, but I want to describe this to you
Does the health icon bopping seem to... snap to the wrong place for a single frame each time the camera bops?
I say this because when I watch the bopping on 0.7.4, it doesn't look like that
No matter what framerate I put it on, the health icons do that
What's good is the FPS doesn't change its behavior, but that behavior seems reeeally subtly bugged

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: reviewing internally Under consideration and testing. labels Sep 29, 2025
@Hundrec Hundrec modified the milestone: 0.7.6 Sep 29, 2025
@PurSnake
Copy link
Copy Markdown
Contributor Author

PurSnake commented Sep 29, 2025

Saving your eyes from infinite frame-snap
image

@PurSnake PurSnake requested a review from Hundrec September 29, 2025 13:32
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Sep 29, 2025
@Hundrec Hundrec added this to the 0.7.6 milestone Sep 29, 2025
@Hundrec Hundrec changed the base branch from develop to dummy/develop-v0.7.5 September 29, 2025 14:01
Hundrec
Hundrec approved these changes Sep 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, everything looks right!

@Hundrec Hundrec merged commit 040ac2a into FunkinCrew:dummy/develop-v0.7.5 Sep 29, 2025
4 checks passed
@LeGooeyy
Copy link
Copy Markdown

LeGooeyy commented Sep 29, 2025

its real... i cant believe it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hundrec Hundrec Hundrec approved these changes

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.

Milestone

0.8.0 - SPAGHETTI Collab Update

Development

Successfully merging this pull request may close these issues.

5 participants

@PurSnake @trayfellow @LeGooeyy @Hundrec @AbnormalPoof