[OPTIMIZATION] Refactor: cleaner and faster time formatter#6049
Merged
Conversation
github-actions
Bot
added
status: pending triage
Member
|
Excellent! How's this @MAJigsaw77? |
Hundrec
added
type: optimization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
replaced repeated Math.pow(10, decimals) calls with a single precomputed factor.
simplified the seconds formatting branch into a concise ternary expression.
i made this for performance-wise because
Math.powis relatively expensive compared to arithmetic. The old code recomputed it for every unit, even though it only matters for seconds. now it's computed once.small gain but measurable in tight loops or frequent calls.
The ternary
(u.name == "second" ? ... : ...)makes it clear that seconds are special-cased without spreading logic across multiple branches.i've also change variable names (u instead of unit)
precomputed factor makes decimals handling self-contained and predictable.