Skip to content

[ENHANCEMENT/TWEAK] Add offset var to note in NoteStyle.hx#6326

Merged
AbnormalPoof merged 1 commit into
FunkinCrew:dummy/develop-v0.7.5from
NebulaStellaNova:patch-1
Nov 23, 2025
Merged

[ENHANCEMENT/TWEAK] Add offset var to note in NoteStyle.hx#6326
AbnormalPoof merged 1 commit into
FunkinCrew:dummy/develop-v0.7.5from
NebulaStellaNova:patch-1

Conversation

@NebulaStellaNova
Copy link
Copy Markdown
Contributor

@NebulaStellaNova NebulaStellaNova commented Oct 21, 2025 •
edited
Loading

Description

Adds the ability to offset the actual notes, not entirely sure why this wasn't already a thing (unless it is)

I also made a script version of it but it would be better if it existed already

@github-actions github-actions Bot added status: pending triage Awaiting review. size: tiny A tiny pull request with 4 or fewer changes. pr: haxe PR modifies game code. labels Oct 21, 2025
@NebulaStellaNova NebulaStellaNova changed the title Add offset var to note in NoteStyle.hx [ENHANCEMENT/TWEAK] Add offset var to note in NoteStyle.hx Oct 21, 2025
@NebulaStellaNova NebulaStellaNova changed the base branch from main to develop October 21, 2025 17:25
@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Oct 21, 2025
@github-actions github-actions Bot added size: small A small pull request with 10 or fewer changes. and removed size: tiny A tiny pull request with 4 or fewer changes. labels Oct 21, 2025
@PurSnake PurSnake mentioned this pull request Nov 9, 2025
Closed
4 tasks
@Hundrec Hundrec linked an issue Nov 15, 2025 that may be closed by this pull request
Bug Report: NoteStyle attribute "assets.note.offsets" gets ignored #6408
Closed
4 tasks
@TechnikTil @NebulaStellaNova @AbnormalPoof
Add offset var to note in NoteStyle.hx
d8fc623 
Co-authored-by: NebulaStellaNova <78160470+NebulaStellaNova@users.noreply.github.com>
@AbnormalPoof AbnormalPoof added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Nov 23, 2025
@AbnormalPoof AbnormalPoof added this to the 0.7.6 milestone Nov 23, 2025
@AbnormalPoof AbnormalPoof changed the base branch from develop to dummy/develop-v0.7.5 November 23, 2025 11:10
@AbnormalPoof AbnormalPoof merged commit 49b78c4 into FunkinCrew:dummy/develop-v0.7.5 Nov 23, 2025
4 checks passed
@AbnormalPoof AbnormalPoof added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Nov 23, 2025
@AbnormalPoof AbnormalPoof removed the request for review from EliteMasterEric November 23, 2025 11:14
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. and removed type: enhancement Involves an enhancement or new feature. labels Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.

Milestone

0.8.0 - SPAGHETTI Collab Update

Development

Successfully merging this pull request may close these issues.

Bug Report: NoteStyle attribute "assets.note.offsets" gets ignored

4 participants

@NebulaStellaNova @AbnormalPoof @Hundrec @TechnikTil