[BUGFIX] Chart Editor - Ctrl click on hold note NOR fix (again) #6912
Merged
Conversation
github-actions
Bot
added
status: pending triage
Member
|
I did this internally a few days ago, but haven't gotten around to pushing it |
Hundrec
added
type: major bug
Lasercar
deleted the
bugfix/chart-editor-ctrl-click-on-hold-note-NOR-fix-(again)
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
None (and hopefully this issue continues to stay that way).
Description
Ctrl clicking on a hold note causes a null reference error because it tries to check if a regular note is selected, rather than a hold note.
This simply changes it to check for a hold note instead.
Now also includes a comment specifying the issue this fixes so that the change doesn't get reverted again in the future.