Merged
Conversation
We don't actually want indirection within Cloud Hypervisor anymore, as now we actually want them to be inside the actors themselves
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| async fn on_stop( | ||
| &mut self, | ||
| actor_ref: WeakActorRef<Self>, |
| @@ -1,8 +1,8 @@ | |||
|
|
|||
| use serde::{Deserialize, Serialize}; | |||
| @@ -1,8 +1,8 @@ | |||
|
|
|||
| use serde::{Deserialize, Serialize}; | |||
| use stable_eyre::Result; | ||
| use std::cell::RefCell; | ||
| use tracing::{debug, info, warn}; | ||
| use std::time::Duration; |
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: rui314/setup-mold@v1 |
| - uses: actions/checkout@v4 | ||
| - uses: rui314/setup-mold@v1 | ||
| - name: Run sccache-cache | ||
| uses: mozilla-actions/sccache-action@v0.0.9 |
| override: true | ||
|
|
||
|
|
||
| - uses: rui314/setup-mold@v1 |
|
|
||
| - uses: rui314/setup-mold@v1 | ||
| - name: Run sccache-cache | ||
| uses: mozilla-actions/sccache-action@v0.0.9 |
Closed
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Collaborator
Author
|
The whole codebase was unstable so this is to rebase this to the main branch, the featureset for VM Agents should be done. We will be protecting main eventually, but probably not now since the architecture is still pretty unstable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's merge this for now, as the VM Agents part has been completed