Draft
Conversation
* current tests pass * minor clarifications * fix test and heading for only one point is fine * changed comment * make test stable * no need to check edge twice as it is the same segment for both directions; do not forget to check end pillar node in distance calc * only calc heading of geometry first (graphhopper#2415) * only calc heading of geometry first * Fix test (?!) * minor * Flip heading edge filter condition * move method and add comments * minor Co-authored-by: Andi <easbar.mail@posteo.net>
* Make sure GHDirectory#find only uses each name once * Rename Directory#find -> Directory#create
…n tiles" This reverts commit 9c184bb.
Co-authored-by: Thomas Butz <thomas.butz@optitool.de>
* use jdk17 ga and jdk18 ea * adoptopenjdk is adoptium and I cannot find ea versions, so use the default ones (sormuras/bach -> install-jdk.properties) * since jdk17 locale IDs changed
Co-authored-by: Thomas Butz <thomas.butz@optitool.de>
…riers at junctions
…ndleNodeTags with isBarrier (graphhopper#2434)
…d more barrier edges since b7e286e
Co-authored-by: Thomas Butz <thomas.butz@optitool.de> Co-authored-by: Andi <easbar.mail@posteo.net>
…uld only run for import, not load
* there is no need to first add the configs and then the preparations (at least not anymore)
* use hopper.setGraphHopperLocation(ghLocation);hopper.load() instead of hopper.load(ghLocation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to import individual GH 5 features as listed in release notes by merging them one-by-one an resolving possible conflicts,
where
<commit>is the corresponding GH merge commit hash obtained from the list.