Skip to content

apply geometry checks to all stages in elementsFullHistory requests#151

Merged
tyrasd merged 7 commits intomasterfrom
fix-issue109
Mar 18, 2021
Merged

apply geometry checks to all stages in elementsFullHistory requests#151
tyrasd merged 7 commits intomasterfrom
fix-issue109

Conversation

@tyrasd
Copy link
Copy Markdown
Member

@tyrasd tyrasd commented Mar 17, 2021

Description

Updates addEntityToOutput method to check geometry filters not only in the deprecated "simpleFeatureTypes" code path.

Corresponding issue

Closes #109

Checklist

@tyrasd tyrasd added the bug Something isn't working label Mar 17, 2021
@tyrasd tyrasd force-pushed the fix-issue109 branch 3 times, most recently from 2ce2440 to 42639da Compare March 17, 2021 18:41
@tyrasd tyrasd requested a review from KowatschFab March 17, 2021 18:42
@tyrasd tyrasd added the waiting for review This pull request needs a code review label Mar 17, 2021
@tyrasd
Copy link
Copy Markdown
Member Author

tyrasd commented Mar 17, 2021

strictly speaking, cd57e8a is unrelated to #109, but I thought it might still be nice to have all defined tests to be executed on jenkins 😉

@KowatschFab
Copy link
Copy Markdown
Contributor

strictly speaking, cd57e8a is unrelated to #109, but I thought it might still be nice to have all defined tests to be executed on jenkins 😉

You mean jenkins only executes tests that have explicitly Test written in the method name..? :O

@tyrasd
Copy link
Copy Markdown
Member Author

tyrasd commented Mar 18, 2021

You mean jenkins only executes tests that have explicitly Test written in the method name..? :O

Oh, forget what I wrote. I miscounted the tests that should be executed and falsely remembered that test methods should have the same naming scheme as the test classes (see https://stackoverflow.com/a/6178629/1627467). Actually, this doesn't apply to the method names, so it was already working fine and didn't need a fix. I would say we still keep the changes from cd57e8a (now b3d5112), since it makes all test method have a uniform naming scheme.

Copy link
Copy Markdown
Contributor

@KowatschFab KowatschFab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments.

@tyrasd tyrasd requested a review from KowatschFab March 18, 2021 09:39
@KowatschFab
Copy link
Copy Markdown
Contributor

You mean jenkins only executes tests that have explicitly Test written in the method name..? :O

Oh, forget what I wrote. I miscounted the tests that should be executed and falsely remembered that test methods should have the same naming scheme as the test classes (see https://stackoverflow.com/a/6178629/1627467). Actually, this doesn't apply to the method names, so it was already working fine and didn't need a fix. I would say we still keep the changes from cd57e8a (now b3d5112), since it makes all test method have a uniform naming scheme.

Ok I see.. Since it's only important for the classes to follow the specific format, my idea was to remove then the superfluous Test at the end of every method. That's why I did not add it to the new tests. And I did not want to change all test names within that branch. Should have created an issue for that I guess so it would not get forgotten..

@tyrasd tyrasd merged commit 529faeb into master Mar 18, 2021
@tyrasd tyrasd deleted the fix-issue109 branch March 18, 2021 10:17
@tyrasd tyrasd removed the waiting for review This pull request needs a code review label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

elementsFullHistory: geometry type filter not applied on all returned features

2 participants