fix(ci): preserve native desktop assets during builds#3448
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76aa6ecab1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Visit the preview URL for this PR (updated for commit e5d800f): https://walletrc--pull-3448-merge-f2f9n4o4.web.app (expires Wed, 25 Mar 2026 20:12:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
The blanket removal of the build directory wipe between the asset-fetching and real build passes caused web workflows to skip copy_assets and reuse the stale AssetManifest.bin from the warm-up run. Restore the cleanup using a find command that wipes all build caches except native_assets, which desktop builds generate and need to reuse.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flutter buildruns in the shared generate-assets actionlldto the Docker Linux build image so Dart AOT can find the linker it expectsRoot cause
build/native_assets/linuxbetween builds, which caused CMake install to failld.lld/lldValidation
bash -nflutter analyzelocally; the repository still has many pre-existing analyzer findings unrelated to this change