Conversation
We don't want the build to fail with the next `ubuntu-latest` update, so for now, we will stick with `ubuntu-22.04`, which is working perfectly.
|
It would probably be a good idea, while currently editing such things, to remove the dependency bits that are already installed on the runners in order to same time and simplify maintenance |
temp solution which purpose is to clean artifacts between build for various platforms
Merged
smk762
suggested changes
Mar 21, 2025
zcutil/clean-help-dev.sh
Outdated
| # search for *.a, *.la, *.o, *.lo, *.Plo, *.Po, *.lai, *.dirstamp in all folders starting from .src, including hidden folders, | ||
| # to search only in hidden folders add -path "*/.*" arg to command | ||
| find ./src \( -name "*.a" -o -name "*.la" -o -name "*.o" -o -name "*.lo" -o -name "*.Plo" -o -name "*.Po" -o -name "*.lai" -o -name "*.dirstamp" \) -delete | ||
|
|
There was a problem hiding this comment.
Add echo "Remnant build files deleted!" for positive outcome user feedback
zcutil/clean-help-dev.sh
Outdated
| is_git_root=0 | ||
| else | ||
| if [ "$dir" != "$(pwd)" ]; then | ||
| echo "$(pwd) is not the root of the Git repository." |
There was a problem hiding this comment.
add Exiting... to communicate negative outcome user feedback
zcutil/clean-help-dev.sh
Outdated
| done | ||
|
|
||
| if [ "$dir" == "" ]; then | ||
| echo "$(pwd) is not in a Git repository." |
There was a problem hiding this comment.
add Exiting... to communicate negative outcome user feedback
Author
There was a problem hiding this comment.
Fixed. Let's approve and merge it first, since all other PRs go through the Windows build, and it fails because this one hasn't been accepted yet.
smk762
approved these changes
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please don't merge this PR until all workflows in CI complete successfully. If everything goes well, the CD workflow with the Windows build should also succeed, as they are currently the same. I will leave an additional comment when it is ready for merging.