Skip to content

Update DEPRECATION_HEIGHT to 5 333 777 to extend node support window#651

Merged
ca333 merged 1 commit intodevfrom
patch-update-deprecation-height
Jul 17, 2025
Merged

Update DEPRECATION_HEIGHT to 5 333 777 to extend node support window#651
ca333 merged 1 commit intodevfrom
patch-update-deprecation-height

Conversation

@DeckerSU
Copy link

@DeckerSU DeckerSU commented Jun 8, 2025

We’ve extended the deprecation height to 5 333 777—about 619 days (1.5 years) ahead—so every node has plenty of time to upgrade before the auto-shutdown kicks in. At roughly 500 000 blocks per year (≈1 400 blocks/day), this change gives about 18 months of lead time for exchanges, services, and end users to deploy the new release without interruption.

@DeckerSU DeckerSU force-pushed the patch-update-deprecation-height branch from f893b3a to e1075cb Compare June 12, 2025 00:53
@DeckerSU DeckerSU changed the title update DEPRECATION_HEIGHT to 5050000 (current time + ~blocks per year) Update DEPRECATION_HEIGHT to 5 333 777 to extend node support window Jun 12, 2025
@DeckerSU DeckerSU requested a review from ca333 June 12, 2025 01:07
DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Jun 12, 2025
We’ve extended the deprecation height to 5 333 777—about 619 days (1.5 years) ahead—so every node has plenty of time to upgrade before the auto-shutdown kicks in. At roughly 500 000 blocks per year (≈1 400 blocks/day), this change gives about 18 months of lead time for exchanges, services, and end users to deploy the new release without interruption.

GLEECBTC/komodo-daemon#651
@TheComputerGenie
Copy link

Shouldn't the logical deprecation height be based on an assumption/anticipation date of the next hard fork plus a buffer?
18 months seems needlessly excessive unless the plan is to change seasons on 18 month schedule rather than yearly, as it would create times where there's no meaningful change other than changing a variable shortly after having updated for seasons change.

Example:
deprecation height updated 18 months in advance
hf happens at month 15
month 18, 3 months after hf update, user must "update" a soft fork that may be no change other than deprecation height variable

@ca333
Copy link

ca333 commented Jul 17, 2025

Shouldn't the logical deprecation height be based on an assumption/anticipation date of the next hard fork plus a buffer? 18 months seems needlessly excessive unless the plan is to change seasons on 18 month schedule rather than yearly, as it would create times where there's no meaningful change other than changing a variable shortly after having updated for seasons change.

Example: deprecation height updated 18 months in advance hf happens at month 15 month 18, 3 months after hf update, user must "update" a soft fork that may be no change other than deprecation height variable

we plan to transition to KMD 2.0 (new protocol basis, PoS, etc.) by then thus added a bit of a buffer to not have to roll out another "depr height update" in the mean-time.

@ca333 ca333 merged commit 0a55802 into dev Jul 17, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants