Fix fetch script on macos

[gcharang]

re: GLEECBTC/komodo-defi-framework#2603

please verify the scripts work in both MacOs and linux

[DeckerSU]

The script assumes that coreutils is installed, which is why it uses sha256sum instead of shasum or openssl dgst -sha256. Of course, we could approve these changes, or even add a fallback to calculate sha256 in a different way - for example, if sha256sum is not found, try openssl or shasum. But is that really necessary?

[gcharang]

@DeckerSU as can be seen in GLEECBTC/komodo-defi-framework#2603 , the macos test was failing at this fetch script because there was a sha256sum command available but with a seemingly different parameter requirement than the linux one. I saw the same behavior in my local macos. I checked and don't have coreutils installed. Maybe the latest macos comes bundled with a different sha256sum command

sha256sum --version says just sha256sum (Darwin) 1.0. doesn't mention GNU coreutils at all like the same command on linux does

We need to fix this for the kdf test github action to work

[DeckerSU]

Wouldn't it be simpler to do something like:

- name: Install coreutils on macOS
  if: matrix.os == 'macos-latest'
  run: brew install coreutils

before https://github.com/KomodoPlatform/komodo-defi-framework/blob/a9fbf6096257b802e0aac4d936dcc5d2f0c28461/.github/workflows/test.yml#L155?

If that is not appropriate for some reason, I will approve this PR - consider it just a suggestion.

[gcharang]

@DeckerSU we need to fix the fetch scripts for macos users of komodod too. Like it did in my local mac, the current scripts will fail for other users of latest macos as well

[DeckerSU]

p.s. I also think (haven’t tested it yet, but I will) that we can fix the error by changing in the script:

        "$SHA256CMD" $SHA256ARGS -c <<EOF
$expectedhash  $dlname

to:

        "$SHA256CMD" $SHA256ARGS -c - <<EOF
$expectedhash  $dlname

so that sha256sum -c - is executed instead of sha256sum -c.

I’ll try it today and post the results. I think the root of the issue is related to that.

[DeckerSU]

Yes, I’ve checked. With the changes below, everything should work as expected. Please test as well, remove your changes in this PR and apply the one below instead.

diff --git a/zcutil/fetch-params.sh b/zcutil/fetch-params.sh
index 930a8691a..d275273d9 100755
--- a/zcutil/fetch-params.sh
+++ b/zcutil/fetch-params.sh
@@ -115,7 +115,7 @@ function fetch_params {
             fi
         done

-        "$SHA256CMD" $SHA256ARGS -c <<EOF
+        "$SHA256CMD" $SHA256ARGS -c -<<EOF
 $expectedhash  $dlname
 EOF

[gcharang]

@DeckerSU it works. tested on mac and linux. please approve