GLib.Opaque: Drop extra reference when object is un-owned before dispose#51
Open
xhaakon wants to merge 1 commit into
Open
GLib.Opaque: Drop extra reference when object is un-owned before dispose#51xhaakon wants to merge 1 commit into
xhaakon wants to merge 1 commit into
Conversation
If the Owned property of a Gst.MiniObject (base class Opaque) is set from true to false during its lifetime, its reference count is not decremented. For example when Gst.Event (derived from Gst.MiniObject) is created using Gst.Event.NewEos(), Gst.MiniObject.Ref() increments its ref count and sets Owned = true. Then, passing the event to Gst.Pad.PushEvent(), sets Owned = false, but this change won't remove the extra reference that MiniObject.Ref() added earlier and it won't get cleared even when Unref() gets eventualy called from Dispose(), because Gst.MiniObject.Unref() only decrements ref count of objects that are Owned. This change Unref()s the object when Owned property gets set to false.
xhaakon
force-pushed
the
fix-ref-leak-opaque-owned
branch
from
c18ed8f to
f47b66b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the Owned property of a Gst.MiniObject (base class Opaque) is set
from true to false during its lifetime, its reference count is not
decremented.
For example when Gst.Event (derived from Gst.MiniObject) is created
using Gst.Event.NewEos(), Gst.MiniObject.Ref() increments its ref count
and sets Owned = true. Then, passing the event to Gst.Pad.PushEvent(),
sets Owned = false, but this change won't remove the extra reference
that MiniObject.Ref() added earlier and it won't get cleared even when
Unref() gets eventualy called from Dispose(), because
Gst.MiniObject.Unref() only decrements ref count of objects that are
Owned.
This change Unref()s the object when Owned property gets set to false.