bring code from the notifications-python-client project into our project#1766
Merged
bring code from the notifications-python-client project into our project#1766
Conversation
added 2 commits
June 10, 2025 10:33
terrazoon
changed the title
alexjanousekGSA
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The notifications-python-client package that is maintained by Notify UK is on an old version of urllib3, which is causing our app to fail when we upgrade to python 3.13 due to changes in certificate handling.
Bring the code from that package directly into our app, because we are using the latest version of urllib3.
Security Considerations
Improve our ability to fix security issues in this package by getting our own copy of the code.