Merged
Conversation
added 2 commits
August 13, 2025 12:21
heyitsmebev
approved these changes
Aug 13, 2025
ccostino
approved these changes
Aug 13, 2025
Contributor
ccostino
left a comment
ccostino
left a comment
There was a problem hiding this comment.
Nice catch, thank you @terrazoon!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue originally reported almost 2 years ago was that the Notification.updated_at field was updating continuously, and the change in the value had nothing to do with when the object was actually updated.
I'm not seeing that now -- not reproducible.
However, setting:
onupdate=utc_now()
instead of
onupdated=utcnow
means that the value gets fixed at the time the models classes load, and then stays frozen, which is not what we want. So fix that.
Security Considerations
N/A