Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
2ea52b1
fix job details
Aug 22, 2025
96b6961
fix test
Aug 22, 2025
8502b6c
fix test
Aug 22, 2025
9ae4075
fix test
Aug 22, 2025
f4b2091
fix test
Aug 22, 2025
07c9d26
fix test
Aug 22, 2025
fb8fed2
fix test
Aug 22, 2025
7f38cee
fix test
Aug 22, 2025
49affd9
fix test
Aug 22, 2025
46a1a92
fix test
Aug 22, 2025
f29ed95
fix test
Aug 22, 2025
c32ece1
Bump lxml from 6.0.0 to 6.0.1 (#1927)
dependabot[bot] Aug 25, 2025
c3e5f0b
Merge pull request #1926 from GSA/job_details
ccostino Aug 25, 2025
86458fe
Added changes to support extra day in activity chart (#1928)
alexjanousekGSA Aug 25, 2025
5b4563c
Bump moto from 5.1.10 to 5.1.11 (#1932)
dependabot[bot] Aug 26, 2025
bf72682
Bump cachetools from 6.1.0 to 6.2.0 (#1929)
dependabot[bot] Aug 26, 2025
866ba24
Bump typing-extensions from 4.14.1 to 4.15.0 (#1930)
dependabot[bot] Aug 26, 2025
255b332
Bump beautifulsoup4 from 4.13.4 to 4.13.5 (#1931)
dependabot[bot] Aug 26, 2025
0a0a3d9
Bump faker from 37.5.3 to 37.6.0
dependabot[bot] Aug 27, 2025
55444db
Merge pull request #1934 from GSA/dependabot/pip/faker-37.6.0
ccostino Aug 27, 2025
52e68eb
Added code to delete files that are stale (#1936)
alexjanousekGSA Aug 27, 2025
cc1909b
Fix Demo environment SSB AWS regions
ccostino Aug 27, 2025
f69d3f1
Merge pull request #1937 from GSA/fix-demo-ssb-references
heyitsmebev Aug 27, 2025
9911060
Bump alembic from 1.16.4 to 1.16.5 (#1938)
dependabot[bot] Aug 28, 2025
9d2a23b
Update Demo SSB References Again
ccostino Aug 28, 2025
6c5534b
Merge pull request #1939 from GSA/fix-demo-ssb-references-again
heyitsmebev Aug 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
Kenneth Kehl committed Aug 22, 2025
commit 7f38ceeb0307136f8a33d652fbe87beac27817dd
21 changes: 14 additions & 7 deletions tests/app/job/test_rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,28 +533,35 @@ def test_get_recent_notifications_for_job_in_reverse_order_of_job_number(


@pytest.mark.parametrize(
"expected_notification_count, status_args",
"expected_notification_count, status_args, expected_phones, expected_personalisation",
[
(1, [NotificationStatus.CREATED]),
(0, [NotificationStatus.SENDING]),
(1, [NotificationStatus.CREATED, NotificationStatus.SENDING]),
(0, [NotificationStatus.SENDING, NotificationStatus.DELIVERED]),
(1, [NotificationStatus.CREATED], {0: "15555555555"}, {0: ""}),
(0, [NotificationStatus.SENDING], {}, {}),
(
1,
[NotificationStatus.CREATED, NotificationStatus.SENDING],
{0: "15555555555"},
{0: ""},
),
(0, [NotificationStatus.SENDING, NotificationStatus.DELIVERED], {}, {}),
],
)
def test_get_all_notifications_for_job_filtered_by_status(
admin_request,
sample_job,
expected_notification_count,
status_args,
expected_phones,
expected_personalisation,
mocker,
):

mock_job = mocker.patch("app.job.rest.get_job_from_s3")
mock_job.return_value = None
mock_s3 = mocker.patch("app.job.rest.extract_phones")
mock_s3.return_value = {0: "15555555555"}
mock_s3.return_value = expected_phones
mock_s3_personalisation = mocker.patch("app.job.rest.extract_personalisation")
mock_s3_personalisation.return_value = {0: ""}
mock_s3_personalisation.return_value = expected_personalisation
sample_job.job_row_number = 0

create_notification(job=sample_job, to_field="1", status=NotificationStatus.CREATED)
Expand Down
Loading