Conversation
ccostino
approved these changes
Sep 5, 2025
Contributor
ccostino
left a comment
ccostino
left a comment
There was a problem hiding this comment.
Thanks @heyitsmebev, nice catch! This should handle things much more gracefully! 🙂
ccostino
deleted the
2899-when-users-view-old-jobs-the-code-crashes-trying-to-read-deleted-csv-files-500-error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle StopIteration in extract_phones when CSV files are empty/missing
When users view old jobs, the code crashes trying to read deleted CSV files.
17:35:14.970: [APP/PROC/WEB.1] {"name": "app", "levelname": "ERROR", "message": "", "pathname": "/home/vcap/app/app/errors.py", "lineno": 110, "exc_info": "Traceback (most recent call last):\n File "/home/vcap/deps/0/python/lib/python3.12/site-packages/flask/app.py", line 917, in full_dispatch_request\n rv = self.dispatch_request()\n ^^^^^^^^^^^^^^^^^^^^^^^\n File "/home/vcap/deps/0/python/lib/python3.12/site-packages/flask/app.py", line 902, in dispatch_request\n return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args) # type: ignore[no-any-return]\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/home/vcap/deps/0/python/lib/python3.12/site-packages/newrelic/hooks/framework_flask.py", line 73, in nr_wrapper_handler\n return wrapped(*args, **kwargs)\n ^^^^^^^^^^^^^^^^^^^^^^^^\n File "/home/vcap/app/app/job/rest.py", line 82, in get_all_notifications_for_service_job\n phones = extract_phones(job, service_id, job_id)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/home/vcap/app/app/aws/s3.py", line 479, in extract_phones\n first_row = next(csv_reader)\n ^^^^^^^^^^^^^^^^\nStopIteration", "time": "2025-09-05T00:35:14", "requestId": "5916f9d4987e4ae3558c5b1d1dfd8001", "application": "app", "service_id": "notify-admin", "logType": "application"}