Conversation
ccostino
reviewed
Oct 3, 2025
Contributor
ccostino
left a comment
ccostino
left a comment
There was a problem hiding this comment.
Thanks @terrazoon!
I agree about testing this in isolation when we merge it - I had one question on the new methods introduced, but I could very well not be seeing something!
ccostino
approved these changes
Oct 3, 2025
Contributor
ccostino
left a comment
ccostino
left a comment
There was a problem hiding this comment.
Thanks again, @terrazoon!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because of the use of gevent and its need for monkey patching, it's necessary that all global variables that use resources be lazily initialized. This way the monkey patching works for the whole app, and we don't get fork errors under heavy load.
In the PR we do lazy initialization of all the 'easy' global variables, which don't hit too many files.
Note: This PR is a bit risky. Even though I ran a bulk send test locally and it was successful, the PR might destabilize staging. So we should push it to staging on its own and QA test it on its own, and be ready to rollback.
Security Considerations
N/A