Skip to content

migrate module.ses_email to new provider#2057

Merged
terrazoon merged 4 commits intomainfrom
terraform_upgrade1
Oct 24, 2025
Merged

migrate module.ses_email to new provider#2057
terrazoon merged 4 commits intomainfrom
terraform_upgrade1

Conversation

@terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Oct 23, 2025 •
edited
Loading

Description

Delete the old module.ses_email and rebuild it, pointing to the new terraform provider.

Security Considerations

N/A

@terrazoon terrazoon self-assigned this Oct 23, 2025
@terrazoon terrazoon marked this pull request as draft October 23, 2025 19:02
ccostino
ccostino approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon, 🤞 this does what we expect it to do!

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Terraform Format and Style: success
Terraform Initialization: failure
Terraform Validation: skipped
Terraform Plan: skipped

Show Plan

Pusher: @terrazoon, Action: pull_request

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan 

null_resource.prevent_destroy: Refreshing state... [id=8846663655257903885]
module.redis-v70.data.cloudfoundry_service_plans.redis: Reading...
data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service_plans.redis: Read complete after 1s [name=redis-dev]
data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=38cb2a87-8882-4f8e-8b47-5ddec3e2a993]
module.csv_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=b15631b3-00fb-49f6-a4d3-ebaedfca1cd9]
module.egress-space.data.cloudfoundry_org.org: Reading...
module.sns_sms.data.cloudfoundry_space.space: Reading...
module.csv_upload_bucket_old.data.cloudfoundry_service.s3: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Reading...
module.database.data.cloudfoundry_space.space: Reading...
module.csv_upload_bucket_old.data.cloudfoundry_space.space: Reading...
module.database.data.cloudfoundry_service.rds: Reading...
module.ses_email.cloudfoundry_service_instance.ses: Refreshing state... [id=bc6b3f0b-dc2f-4b46-84d1-3940c29693d7]
module.sns_sms.data.cloudfoundry_service.sns: Read complete after 0s [id=9c59e780-af5a-4a89-ac31-591a3ae1347e]
module.csv_upload_bucket_old.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.database.data.cloudfoundry_service.rds: Read complete after 0s [id=dcfb1d43-f22c-42d3-962c-7ae04eda24e7]
module.egress-space.data.cloudfoundry_org.org: Read complete after 0s [id=9e428562-a2d9-41b4-9c23-1ef5237fb44e]
module.egress-space.cloudfoundry_space.public_egress: Refreshing state... [id=21b58751-362b-433a-a285-8a1455d9634f]
module.egress-space.data.cloudfoundry_user.users["dee18960-b0b1-462b-81f4-f570c7fbe7ef"]: Reading...
module.egress-space.data.cloudfoundry_user.users["carlo.costino@gsa.gov"]: Reading...
module.sns_sms.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.csv_upload_bucket_old.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.sns_sms.cloudfoundry_service_instance.sns: Refreshing state... [id=fd12400d-7827-4b16-9ef0-d4277e873fda]
module.database.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.database.cloudfoundry_service_instance.rds: Refreshing state... [id=b8caaa4f-b3b8-4dbc-ba16-95d3899be5a0]
module.egress-space.data.cloudfoundry_user.users["dee18960-b0b1-462b-81f4-f570c7fbe7ef"]: Read complete after 1s [id=8b349fbb-2879-4762-9fe7-1ee9a44123e5]
module.egress-space.data.cloudfoundry_user.users["carlo.costino@gsa.gov"]: Read complete after 1s [id=c7b9f5e0-4d1b-43b1-a659-e8fe4f7083a8]
module.egress-space.cloudfoundry_space_users.deployers: Refreshing state... [id=3fbb7982-1e77-4219-cc78-986468887dd7]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.csv_upload_bucket.cloudfoundry_service_instance.bucket will be destroyed
  # (because cloudfoundry_service_instance.bucket is not in configuration)
  - resource "cloudfoundry_service_instance" "bucket" {
      - id                             = "b15631b3-00fb-49f6-a4d3-ebaedfca1cd9" -> null
      - labels                         = {} -> null
      - name                           = "notify-api-csv-upload-bucket-staging" -> null
      - recursive_delete               = true -> null
      - replace_on_params_change       = false -> null
      - replace_on_service_plan_change = false -> null
      - service_plan                   = "021bb2a3-7e11-4fc2-b06b-d9f5938cd806" -> null
      - space                          = "9745decb-4988-4bab-88a4-e3f07b36241c" -> null
      - tags                           = [] -> null
    }

  # module.csv_upload_bucket_old.cloudfoundry_service_instance.bucket will be created
  + resource "cloudfoundry_service_instance" "bucket" {
      + id                             = (known after apply)
      + name                           = "notify-api-csv-upload-bucket-staging"
      + replace_on_params_change       = false
      + replace_on_service_plan_change = false
      + service_plan                   = "021bb2a3-7e11-4fc2-b06b-d9f5938cd806"
      + space                          = "9745decb-4988-4bab-88a4-e3f07b36241c"
      + tags                           = []
    }

  # module.ses_email.cloudfoundry_service_instance.ses will be destroyed
  # (because cloudfoundry_service_instance.ses is not in configuration)
  - resource "cloudfoundry_service_instance" "ses" {
      - id                             = "bc6b3f0b-dc2f-4b46-84d1-3940c29693d7" -> null
      - json_params                    = jsonencode(
            {
              - domain                        = ""
              - email_receipt_error           = "notify-support@gsa.gov"
              - enable_feedback_notifications = true
              - mail_from_subdomain           = "mail"
              - region                        = "us-west-2"
            }
        ) -> null
      - labels                         = {} -> null
      - name                           = "notify-api-ses-staging" -> null
      - recursive_delete               = true -> null
      - replace_on_params_change       = false -> null
      - replace_on_service_plan_change = false -> null
      - service_plan                   = "7630ae30-4883-4f84-b4c7-2779fdf6782f" -> null
      - space                          = "9745decb-4988-4bab-88a4-e3f07b36241c" -> null
      - tags                           = [] -> null
    }

Plan: 1 to add, 0 to change, 2 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @terrazoon, Action: pull_request

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan 

null_resource.prevent_destroy: Refreshing state... [id=8846663655257903885]
module.redis-v70.data.cloudfoundry_service_plans.redis: Reading...
data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service_plans.redis: Read complete after 0s [name=redis-dev]
data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=38cb2a87-8882-4f8e-8b47-5ddec3e2a993]
module.ses_email.cloudfoundry_service_instance.ses: Refreshing state... [id=bc6b3f0b-dc2f-4b46-84d1-3940c29693d7]
module.database.data.cloudfoundry_space.space: Reading...
module.sns_sms.data.cloudfoundry_space.space: Reading...
module.egress-space.data.cloudfoundry_org.org: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Reading...
module.database.data.cloudfoundry_service.rds: Reading...
module.csv_upload_bucket.data.cloudfoundry_space.space: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.sns_sms.data.cloudfoundry_service.sns: Read complete after 0s [id=9c59e780-af5a-4a89-ac31-591a3ae1347e]
module.database.data.cloudfoundry_service.rds: Read complete after 0s [id=dcfb1d43-f22c-42d3-962c-7ae04eda24e7]
module.egress-space.data.cloudfoundry_org.org: Read complete after 0s [id=9e428562-a2d9-41b4-9c23-1ef5237fb44e]
module.egress-space.data.cloudfoundry_user.users["dee18960-b0b1-462b-81f4-f570c7fbe7ef"]: Reading...
module.egress-space.data.cloudfoundry_user.users["carlo.costino@gsa.gov"]: Reading...
module.egress-space.cloudfoundry_space.public_egress: Refreshing state... [id=21b58751-362b-433a-a285-8a1455d9634f]
module.sns_sms.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.sns_sms.cloudfoundry_service_instance.sns: Refreshing state... [id=fd12400d-7827-4b16-9ef0-d4277e873fda]
module.database.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.database.cloudfoundry_service_instance.rds: Refreshing state... [id=b8caaa4f-b3b8-4dbc-ba16-95d3899be5a0]
module.csv_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.csv_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=b15631b3-00fb-49f6-a4d3-ebaedfca1cd9]
module.egress-space.data.cloudfoundry_user.users["dee18960-b0b1-462b-81f4-f570c7fbe7ef"]: Read complete after 1s [id=8b349fbb-2879-4762-9fe7-1ee9a44123e5]
module.egress-space.data.cloudfoundry_user.users["carlo.costino@gsa.gov"]: Read complete after 1s [id=c7b9f5e0-4d1b-43b1-a659-e8fe4f7083a8]
module.egress-space.cloudfoundry_space_users.deployers: Refreshing state... [id=3fbb7982-1e77-4219-cc78-986468887dd7]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # module.ses_email.cloudfoundry_service_instance.ses will be destroyed
  # (because cloudfoundry_service_instance.ses is not in configuration)
  - resource "cloudfoundry_service_instance" "ses" {
      - id                             = "bc6b3f0b-dc2f-4b46-84d1-3940c29693d7" -> null
      - json_params                    = jsonencode(
            {
              - domain                        = ""
              - email_receipt_error           = "notify-support@gsa.gov"
              - enable_feedback_notifications = true
              - mail_from_subdomain           = "mail"
              - region                        = "us-west-2"
            }
        ) -> null
      - labels                         = {} -> null
      - name                           = "notify-api-ses-staging" -> null
      - recursive_delete               = true -> null
      - replace_on_params_change       = false -> null
      - replace_on_service_plan_change = false -> null
      - service_plan                   = "7630ae30-4883-4f84-b4c7-2779fdf6782f" -> null
      - space                          = "9745decb-4988-4bab-88a4-e3f07b36241c" -> null
      - tags                           = [] -> null
    }

Plan: 0 to add, 0 to change, 1 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @terrazoon, Action: pull_request

@terrazoon terrazoon changed the title migrate csv_upload_bucket to new provider migrate module.ses_email to new provider Oct 23, 2025
@terrazoon terrazoon marked this pull request as ready for review October 23, 2025 21:10
@terrazoon terrazoon merged commit bb6438f into main Oct 24, 2025
8 checks passed
@terrazoon terrazoon deleted the terraform_upgrade1 branch October 24, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heyitsmebev heyitsmebev Awaiting requested review from heyitsmebev

@alexjanousekGSA alexjanousekGSA Awaiting requested review from alexjanousekGSA

1 more reviewer

@ccostino ccostino ccostino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@terrazoon terrazoon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terrazoon @ccostino