Skip to content

Advanced Shuffle Editor#70

Merged
Gaming32 merged 41 commits into
mainfrom
new-shuffles
Aug 9, 2021
Merged

Advanced Shuffle Editor#70
Gaming32 merged 41 commits into
mainfrom
new-shuffles

Conversation

@Gaming32

Copy link
Copy Markdown
Owner

This editor allows you to chain shuffles as they run. This PR still allows you to use the old system if you like.

@Gaming32 Gaming32 requested a review from EmeraldBlock July 30, 2021 12:23

@EmeraldBlock EmeraldBlock left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really review internals; comments are primarily on things I noticed from testing and from a scan of what each thing does

some of this stuff was previously brought up in discord

still think double list is better

Comment thread shuffle_editor_test.py Outdated
Comment thread src/dialogs/CustomImageDialog.java
Comment thread src/dialogs/ImportSortDialog.java
Comment thread src/dialogs/ShuffleDialog.java Outdated
Comment thread src/dialogs/ShuffleDialog.java Outdated
Comment thread Noisily sorted.txt
Comment thread src/main/ArrayManager.java Outdated
Comment thread src/main/ArrayManager.java
Comment thread src/dialogs/ShuffleDialog.java
Comment thread src/utils/ShuffleInfo.java
@Gaming32

Gaming32 commented Aug 6, 2021

Copy link
Copy Markdown
Owner Author

So is it ready then @EmeraldBlock?

@EmeraldBlock

Copy link
Copy Markdown
Collaborator

I haven't yet tested the new changes, but if you think it's all fine, yeah

@Gaming32 Gaming32 requested a review from EmeraldBlock August 6, 2021 20:16

@EmeraldBlock EmeraldBlock left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review time tm

Comment thread src/dialogs/ShuffleDialog.java
Comment thread src/utils/ShuffleGraph.java Outdated
Comment thread src/main/ArrayManager.java
Comment thread src/dialogs/ShuffleDialog.java Outdated
Comment thread src/dialogs/ShuffleDialog.java Outdated
Comment thread src/utils/ShuffleGraph.java
Comment thread Noisily sorted.txt Outdated
@Gaming32 Gaming32 merged commit 9f03ab8 into main Aug 9, 2021
@Gaming32 Gaming32 deleted the new-shuffles branch August 10, 2021 20:17
@Gaming32 Gaming32 added enhancement New feature or request new-feature labels Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new-feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants