Translation management for configurable fields

[jfayad]

The translation management should apply to the options of configurable sections.

Including Wysiwyg field types

[akramsarkis]

@jfayad Can you please give more details here, do you mean that for configurable section when I switch from a language to another in a form, I must be able to enter different values for the same field, except for the drop down lists or numbers ?

[mahfouzhseineweev]

@jfayad This is going to a breaking change for the existing configurable sections which doesn't have translations.

The new translation management will try expect an object with translation keys and instead it will find the field values stored as strings.

So for this one I think we also need to support backward compatibility correct ?

[jfayad]

So for this one I think we also need to support backward compatibility correct ?

Yes, but make it a configuration so that out of the box it should enforce the new structure

[mahfouzhseineweev]

So for this one we will also use the default language that we will introduce for the project

[mahfouzhseineweev]

For this one 2 we need to expose a hook to update the data stored for the configurable section, which will solve the fact that we need to have the old values returned as objects with translations ex.: title: "abc" => after using the hook title: {en: "Abc" } etc...

[akramsarkis]

Acceptance testing

• For field in configurable section that are text or wyziwig; if there are multiple language, we should be able to enter translation for them
• In case the site has only one language that is the default language of the site, in the section i must see only the translation of this language
• In view mode if there is multiple language then when switching language the translations must show else only the one of the default language will show

[akramsarkis]

@mahfouzhseineweev don't forget to add automated test for this one and to tell which one they are

[akramsarkis]

@mahfouzhseineweev please find below my feedback

Selective articles

• For the Link CTA, when you click to add a section let say the selective article, it is showing inside [object Object] and this is for any configurable having a url as field

• Still for the selective article, for the cta link I am not able to have a link for english and one for french

Categories article

• Categories are no more showing to choose one

In the console there is the below error, note that there is no problem for the API

[mahfouzhseineweev]

@akramsarkis Regarding what I saw on Maiori website, it seems you haven't performed a full sanity test on the configurable sections, please to perform sanity tests (Adding a new configurable section, editing an existing configurable section) for all of the following sections:

• products list v1
• product facets
• selective articles
• suggested articles
• categories articles

Note: For the cta_link, it is not supposed to have a translation on Maiori as translation redirection is automatically handled by the view component

• I suggest you ask from Julien to add 2 wysiwyg types that are title and description which are needed for the selective articles on Maiori

[akramsarkis]

@mahfouzhseineweev I still have bugs

1. Product facets : When adding the section, even though the field is filled in, it is returning the error message ( whatever language configuration you have, french alone, english alone, both available)

2. Even though I filled in all the fields for Selective articles, when only french is selected for the project, and I add the section, there is the error that the fields are required

[mahfouzhseineweev]

@akramsarkis For the first point, I opened the form, I submitted and I got the error showing correctly.
Then I added an array value and resubmitted, the form was submitted correctly

[mahfouzhseineweev]

@akramsarkis

2. Even though I filled in all the fields for Selective articles, when only french is selected for the project, and I add the section, there is the error that the fields are required

I you want to do that, you have to select your default language as FR and for now you can't do that because maiori is on sections BO prod which doesn't have this update yet. So you should try with Only EN for example and redo the test

[akramsarkis]

@akramsarkis

2. Even though I filled in all the fields for Selective articles, when only french is selected for the project, and I add the section, there is the error that the fields are required

I you want to do that, you have to select your default language as FR and for now you can't do that because maiori is on sections BO prod which doesn't have this update yet. So you should try with Only EN for example and redo the test

Ok for this one , for english there is no problem I tested

[akramsarkis]

@akramsarkis For the first point, I opened the form, I submitted and I got the error showing correctly. Then I added an array value and resubmitted, the form was submitted correctly

Well this is weird, I tried several time and get the error without being able to submit, let me recheck

Ok I rechecked and when you copy past on tree then save there is no problem, I will open an issue on maiori specific however as when selecting text for example and copying past, it considers there is no value which is wrong