Conversation
This adds changes to the astrodata/core.py file from a recent branch merge in DRAGONS. This captures commits: - 1ab28c589db5f6508e649894fe7f330f08c42b5e - e10deb524040e9846be7feb6ac8b9fd6e95b42a4
Adds NDAstroData._slice (handles certain metadata of the same shape as NDAstroData.shape) and adds meta/copy args to NDAstroData.transpose This captures the DRAGONS commits: - 925f5e644d4dd42cab62d8578998ed0d66e4349e - a1429a2eeba9bd5ab0329ae447e90d7318bcca87
This adds changes to astrodata/testing, specifically implementing the ignore argument to a list of ignored keywords (hardcoded). This captures the DRAGONS commits: - 7b22187839eee1993721a72623021883ddaedbaf
This adds a test from DRAGONS that tests access to other planes when an nddata object is sliced/windowed. This captures the DRAGONS commits: - dade5e14d5b7de820a42d54d455ebdd15730ee73
This adds a test for creating a new image projection. Captures the DRAGONS commits: - 021bda79de2912ab197704d4ab44e130969b6c1c
Incorporated changes to the asIRAFSection/as_iraf_section methods. This captures DRAGONS commits: - c4a6f6ddcc782466116d8bd6f0846d4dd62122af
Adds changes to astrodata/wcs.py from DRAGONS, including a new function (create_new_image_projection) and handling transform a different way in fitswcs_image. This handles DRAGONS commits: - e1a0e3029e182f57dc8e8546b423c2a02e668481 - 021bda79de2912ab197704d4ab44e130969b6c1c
There was previously a property that overrode `__dict__` for section objects (a [major antipattern, as this overrides the instance attribute dictionary](https://docs.python.org/3/reference/datamodel.html#object.__dict__)).
teald
added
maintenance
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recent changes to the development version of DRAGONS due to feature merges incorporating changes from 2+ years of commits have brought
astrodataout of sync with DRAGONS in unexpected ways.This PR attempts to capture the changes, especially in tests. They're being brought in together to avoid some overhead.
Changes
AstroDataobjectsAstroNDDataobjectstesting.ADCompare._headerNonehandling to binning inutils.as_iraf_sectionDRAGONSdoes this becauseDRAGONS's version ofastrodatastill uses a bad__dict__override that's been fixed in thisastrodatafor a whilewcs.create_new_image_projectionwcs.fitswcs_imageto include rotationTests
test_access_to_other_planes_when_slicedtotests/unit/test_nddata.pytest_create_new_image_projectiontotests/unit/test_wcs.pyDocumentation
utils.as_iraf_sectiondocstring to includebinningargument