Change ParameterScale default from 0 to 1#866
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default value of the ParameterScale setting from 0 to 1 to improve numerical stability in the GenX energy system optimization model.
- Updated the default
ParameterScalevalue in the settings configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lbonaldo
requested changes
Sep 18, 2025
Collaborator
lbonaldo
left a comment
There was a problem hiding this comment.
We just need to update the tests. I can take care of it.
This PR attempts to change the default value of ParameterScaling from 0 to 1 in order to aide in numerical stability
Changed the default value of the parameter 'scaling' to 1.
6adeeec to
a3fba4f
Compare
lbonaldo
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to change the default value of ParameterScaling from 0 to 1 in order to aide in numerical stability
What type of PR is this? (check all applicable)
Related Tickets & Documents
Checklist
How this can be tested
Post-approval checklist for GenX core developers
After the PR is approved