fix: Fix Frenzy smoke effect intermittently not rendering at 60Hz#533
Open
MrS-ibra wants to merge 1 commit into
Open
fix: Fix Frenzy smoke effect intermittently not rendering at 60Hz#533MrS-ibra wants to merge 1 commit into
MrS-ibra wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the Frenzy ground smoke effect would intermittently fail to render at 60hz.
The object that hosts the Frenzy cloud particle system is destroyed by
DeletionUpdateafter 1 logic frame.At 30Hz, 1 logic frame gives the client 33ms to notice the newly created object and render it before it's destroyed.
At 60Hz, that same 1 frame lifetime only gives ~16ms, which isn't always enough real world time for the client to catch up, hence why the smoke would randomly not work.
On the left - before
On the right - after
Frenzy.mp4