Skip to content

Add support for passing pathlib.Path objects as filenames #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 9 commits into from
Sep 13, 2021
Merged

Add support for passing pathlib.Path objects as filenames #1382

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f159418
Add support for passing `pathlib.Path` into pygmt modules
aitorres Jul 10, 2021
32654d3
Handle `pathlib.Path` as string file paths for virtual files
aitorres Jul 19, 2021
2cea6da
Update docstring to mention support for `pathlib.Path`
aitorres Jul 19, 2021
3bfdb56
Fix length of docstring
aitorres Jul 19, 2021
f91b750
Remove unused import
aitorres Jul 19, 2021
367d6e9
Check for to cover all possible cases of across OSes
aitorres Aug 22, 2021
9dc3fb7
Expand tests to support Windows and POSIX Path classes
aitorres Aug 22, 2021
b3c68ec
Apply suggestions from code review
seisman Sep 9, 2021
296be41
Merge branch 'main' into feature/pathlib-support
weiji14 Sep 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docstring to mention support for pathlib.Path
  • Loading branch information
@aitorres
aitorres committed Jul 19, 2021
commit 2cea6da67727835f6d65cb80641e2aa9e00d9c16
4 changes: 2 additions & 2 deletions pygmt/clib/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,8 +1377,8 @@ def virtualfile_from_data(
check_kind : str
Used to validate the type of data that can be passed in. Choose
from 'raster', 'vector' or None. Default is None (no validation).
data : str or xarray.DataArray or {table-like} or None
Any raster or vector data format. This could be a file name, a
data : str or pathlib.Path or xarray.DataArray or {table-like} or None
Any raster or vector data format. This could be a file name or path, a
raster grid, a vector matrix/arrays, or other supported data input.
x/y/z : 1d arrays or None
x, y and z columns as numpy arrays.
Expand Down