Add load_earth_vertical_gravity_gradient function for Earth vertical gravity gradient dataset #2240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willschlitzer
changed the title
seisman
reviewed
Dec 11, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Dec 13, 2022
doc/api/index.rst
Outdated
| datasets.load_earth_geoid | ||
| datasets.load_earth_magnetic_anomaly | ||
| datasets.load_earth_relief | ||
| datasets.load_earth_vgg |
Member
There was a problem hiding this comment.
Is earth_vgg a good name? Perhaps we should use earth_vertical_gravity_gradient instead?
Contributor
Author
There was a problem hiding this comment.
I debated that, but my decision to use earth_vgg was that earth_vertical_gravity_gradient is super long to type out. My thought is that earth_vgg is unique enough as to not be confusing.
Member
There was a problem hiding this comment.
earth_vertical_gravity_gradientis super long to type out.
Yes, but we have autocompletion so a long name is still easy to type.
My thought is that
earth_vggis unique enough as to not be confusing.
earth_vgg is unique, but it doesn't tell users what the dataset is.
Contributor
Author
There was a problem hiding this comment.
Changed to load_earth_vertical_gravity_gradient
willschlitzer
changed the title
seisman
reviewed
Dec 21, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
…al-gravity-gradient' into load-remote-dataset/earth-vertical-gravity-gradient
seisman
approved these changes
Dec 22, 2022
seisman
added
the
final review call
michaelgrund
approved these changes
Dec 22, 2022
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
7 tasks
seisman
deleted the
load-remote-dataset/earth-vertical-gravity-gradient
branch
seisman
removed
the
final review call
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
load_earth_vertical_gravity_gradientfunction for the Earth vertical gravity gradient dataset.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version