-
Notifications
You must be signed in to change notification settings - Fork 238
Figure.grdview: Fix the default z-plane to the grid z minimum when plane is set to True or only facede_fill/facede_pen is set #4287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
16cf2c3
Figure.grdview: Fix the default z-plane to the grid z minimum when pl…
seisman 3b60b9d
Check GMT version
seisman 604f713
Add a note about upstream bug
seisman 8d09f67
Update pygmt/src/grdview.py
seisman 567415a
Update pygmt/src/grdview.py
seisman 0943d4c
Merge branch 'main' into grdview/facade_pen
seisman 6583ba1
Merge branch 'main' into grdview/facade_pen
seisman ef579dd
Merge branch 'main' into grdview/facade_pen
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
pygmt/tests/baseline/test_grdview_facadepen_default_plane.png.dvc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| outs: | ||
| - md5: cfff4879fbe7ab03d8a304b2622b9782 | ||
| size: 26208 | ||
| - md5: aa725f7d05462e7d272cf7045a7c9913 | ||
| size: 32037 | ||
| hash: md5 | ||
| path: test_grdview_facadepen_default_plane.png |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.