Minor streamwriter changes to allow compression#55
Merged
nalinigans merged 1 commit intodevelopfrom Sep 6, 2024
Merged
Conversation
Member
Author
|
There's this tantalizing comment from one of the Apache Arrow folks that suggests that you can use streams to concurrently write/read here: https://stackoverflow.com/a/69771571 But none of my testing show that to be case so finalizing the buffer with each yield... |
Member
Yep, I saw this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamwriter + compression changes for continued perf testing and k8s deployment